You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by tm...@apache.org on 2020/04/22 17:08:15 UTC
[impala] branch master updated (c4ba8f8 -> a9c4cf9)
This is an automated email from the ASF dual-hosted git repository.
tmarshall pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git.
from c4ba8f8 IMPALA-9574: support ubuntu 18.04 base image
new 3a795b5 IMPALA-9681: Fix LdapImpalaShellTest
new a9c4cf9 Ensure the FE custom cluster tests are run in precommit
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
bin/run-all-tests.sh | 2 +-
.../test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java | 2 +-
shell/impala_shell.py | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
[impala] 01/02: IMPALA-9681: Fix LdapImpalaShellTest
Posted by tm...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tmarshall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 3a795b5af01f6bc88897061776f70dcad8c5bf5b
Author: Thomas Tauber-Marshall <tm...@cloudera.com>
AuthorDate: Tue Apr 21 13:48:30 2020 -0700
IMPALA-9681: Fix LdapImpalaShellTest
LdapImpalaShellTest was broken by IMPALA-3343 which changed the
wording of the startup message printed by impala-shell. This patch
fixes the test.
Change-Id: I9e7070fa6da4085ea858f64141529a7a23a86534
Reviewed-on: http://gerrit.cloudera.org:8080/15777
Reviewed-by: Andrew Sherman <as...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
.../test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java | 2 +-
shell/impala_shell.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java b/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
index 1687130..f2c4561 100644
--- a/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
+++ b/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
@@ -121,7 +121,7 @@ public class LdapImpalaShellTest {
protocol = String.format(protocolTemplate, protocol);
validCommand[1] = protocol;
RunShellCommand.Run(validCommand, /*shouldSucceed*/ true, TEST_USER_1,
- "Starting Impala Shell using LDAP-based authentication");
+ "Starting Impala Shell with LDAP-based authentication");
invalidCommand[1] = protocol;
RunShellCommand.Run(
invalidCommand, /*shouldSucceed*/ false, "", "Not connected to Impala");
diff --git a/shell/impala_shell.py b/shell/impala_shell.py
index dd1d461..549cd71 100755
--- a/shell/impala_shell.py
+++ b/shell/impala_shell.py
@@ -1838,7 +1838,7 @@ def impala_shell_main():
"mechanism (-l)", file=sys.stderr)
raise FatalShellException()
- start_msg = "Starting Impala"
+ start_msg = "Starting Impala Shell"
py_version_msg = "using Python {0}.{1}.{2}".format(
sys.version_info.major, sys.version_info.minor, sys.version_info.micro)
[impala] 02/02: Ensure the FE custom cluster tests are run in
precommit
Posted by tm...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tmarshall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit a9c4cf9745bfacd5c14d46a05fd319562547abfb
Author: Thomas Tauber-Marshall <tm...@cloudera.com>
AuthorDate: Tue Apr 21 13:58:26 2020 -0700
Ensure the FE custom cluster tests are run in precommit
Prior to this patch, in run-all-tests.sh it was required that both
CLUSTER_TEST=true and FE_TEST=true for the FE custom cluster tests to
get run.
This resulted in these tests not getting run in precommit after the
precommit job was split into two runs of separate tests, one with
FE_TEST=true and the other with CLUSTER_TEST=true.
Its probably better to maintain the invariant that all of the tests
can be run by setting each of FE_TEST, BE_TEST, etc. to true one at a
time, so this patch fixes the issue by removing the requirement that
FE_TEST=true for the FE custom cluster tests to be run.
This doesn't introduce any new dependencies since having the FE built
is a requirement for being able to run the non-FE custom cluster tests
anyways.
Change-Id: I111a7993ca6c2f986b496c489f5cf028ee0d5154
Reviewed-on: http://gerrit.cloudera.org:8080/15778
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
bin/run-all-tests.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bin/run-all-tests.sh b/bin/run-all-tests.sh
index e3cfc21..46e35ae 100755
--- a/bin/run-all-tests.sh
+++ b/bin/run-all-tests.sh
@@ -252,7 +252,7 @@ do
export IMPALA_MAX_LOG_FILES="${IMPALA_MAX_LOG_FILES_SAVE}"
# Run the FE custom cluster tests only if not running against S3.
- if [[ "$FE_TEST" == true && "${TARGET_FILESYSTEM}" != "s3" ]]; then
+ if [[ "${TARGET_FILESYSTEM}" != "s3" ]]; then
pushd "${IMPALA_FE_DIR}"
MVN_ARGS=" -Dtest=org.apache.impala.custom*.*Test "
if ! "${IMPALA_HOME}/bin/mvn-quiet.sh" -fae test ${MVN_ARGS}; then