You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/20 15:12:32 UTC

[GitHub] [flink] matriv opened a new pull request, #19537: [FLINK-23589][flink-avro] Support microsecond precision for timestamp

matriv opened a new pull request, #19537:
URL: https://github.com/apache/flink/pull/19537

   ## What is the purpose of the change
   
   Add support for microsecond precision for timestamp in Avro.
   
   
   ## Brief change log
   
     - Add support for microsecond precision for timestamp in `AvroRowDataDeserializationSchema`.
     - Adjust tests to use different digits for `hours:mins:seconds`
     - Adjust tests to use complete timestamp and time when testing micros
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - `AvroRowDataDeSerializationSchemaTest#testSpecificType`
     - Adjusted all other tests to use full data/time when testing timestamp/time with micros
     
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19537: [FLINK-23589][flink-avro] Support microsecond precision for timestamp

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19537:
URL: https://github.com/apache/flink/pull/19537#issuecomment-1104055688

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6356a39386fe80008e3518031bfa2f402bd41dfb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6356a39386fe80008e3518031bfa2f402bd41dfb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6356a39386fe80008e3518031bfa2f402bd41dfb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liuml07 commented on pull request #19537: [FLINK-23589][flink-avro] Support microsecond precision for timestamp

Posted by GitBox <gi...@apache.org>.
liuml07 commented on PR #19537:
URL: https://github.com/apache/flink/pull/19537#issuecomment-1370350926

   I think this PR is not blocked by [FLINK-27331](https://issues.apache.org/jira/browse/FLINK-27331) or [FLINK-17224](https://issues.apache.org/jira/browse/FLINK-17224), though [FLINK-17224](https://issues.apache.org/jira/browse/FLINK-17224) blocks [FLINK-27331](https://issues.apache.org/jira/browse/FLINK-27331). This PR is for TIMESTAMP data type and the two other JIRAs are for TIME.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] matriv commented on pull request #19537: [FLINK-23589][flink-avro] Support microsecond precision for timestamp

Posted by GitBox <gi...@apache.org>.
matriv commented on PR #19537:
URL: https://github.com/apache/flink/pull/19537#issuecomment-1104050390

   Microseconds are not currently supported for TIME, opened: https://issues.apache.org/jira/browse/FLINK-27331 to track this as it's blocked by https://issues.apache.org/jira/browse/FLINK-17224


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] stevenzwu commented on pull request #19537: [FLINK-23589][flink-avro] Support microsecond precision for timestamp

Posted by GitBox <gi...@apache.org>.
stevenzwu commented on PR #19537:
URL: https://github.com/apache/flink/pull/19537#issuecomment-1263847172

   @matriv is this PR blocked by https://issues.apache.org/jira/browse/FLINK-17224 and https://issues.apache.org/jira/browse/FLINK-27331? Without them, will the converters btw Flink RowData and Avro GenericRecord work with the microsecond precision after this fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org