[GitHub] liubao68 commented on a change in pull request #935: [SCB-942]Choose the highest priority from all implementation classes

[GitBox <gi...@apache.org>]

liubao68 commented on a change in pull request #935: [SCB-942]Choose the highest priority from all implementation classes
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/935#discussion_r223244466
 
 

 ##########
 File path: foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/SPIServiceUtils.java
 ##########
 @@ -149,7 +149,7 @@ private SPIServiceUtils() {
     List<T> services = getOrLoadSortedService(serviceType);
     return (IMPL) services
         .stream()
-        .filter(service -> service.getClass().equals(implType))
+        .filter(service -> implType.isAssignableFrom(service.getClass()))
 
 Review comment:
   I have updated the JIRA status. This PR is not valid. Please close it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services