You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/01/31 23:52:54 UTC

[GitHub] [incubator-gobblin] jack-moseley opened a new pull request #2880: [GOBBLIN-1038] Set default dataset descriptor configs based on the DataNode

jack-moseley opened a new pull request #2880: [GOBBLIN-1038] Set default dataset descriptor configs based on the DataNode
URL: https://github.com/apache/incubator-gobblin/pull/2880

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1038

### Description
- [x] Here are some details about my PR, including screenshots (if applicable):

Set default dataset descriptor config for class/platform by including them in each DataNode. For ones like `BaseDataNode` where it doesn't make sense, they are null so there is no default.

Also added a check that all dest nodes are the same type of datanode since it wouldn't work anyway for there to be multiple types.

## Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:

### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-gobblin] asfgit closed pull request #2880: [GOBBLIN-1038] Set default dataset descriptor configs based on the DataNode

Posted by GitBox <gi...@apache.org>.

asfgit closed pull request #2880: [GOBBLIN-1038] Set default dataset descriptor configs based on the DataNode
URL: https://github.com/apache/incubator-gobblin/pull/2880
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] jack-moseley commented on issue #2880: [GOBBLIN-1038] Set default dataset descriptor configs based on the DataNode

Posted by GitBox <gi...@apache.org>.

jack-moseley commented on issue #2880: [GOBBLIN-1038] Set default dataset descriptor configs based on the DataNode
URL: https://github.com/apache/incubator-gobblin/pull/2880#issuecomment-580960134
 
 
   @arjun4084346 please review

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] jack-moseley commented on a change in pull request #2880: [GOBBLIN-1038] Set default dataset descriptor configs based on the DataNode

Posted by GitBox <gi...@apache.org>.

jack-moseley commented on a change in pull request #2880: [GOBBLIN-1038] Set default dataset descriptor configs based on the DataNode
URL: https://github.com/apache/incubator-gobblin/pull/2880#discussion_r373739366
 
 

 ##########
 File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/pathfinder/AbstractPathFinder.java
 ##########
 @@ -103,6 +105,11 @@
       this.destNodes.add(destNode);
     }
 
+    // All dest nodes should be the same class
+    if (this.destNodes != null && this.destNodes.stream().map(Object::getClass).collect(Collectors.toSet()).size() > 1) {
 
 Review comment:
   This is the destination nodes specified by the user in the `destinationIdentifiers` property, it allows more than one. This makes it explicitly fail if they specified an HDFS and mysql cluster for example (which would probably fail somewhere else in compilation anyway).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] arjun4084346 commented on a change in pull request #2880: [GOBBLIN-1038] Set default dataset descriptor configs based on the DataNode

Posted by GitBox <gi...@apache.org>.

arjun4084346 commented on a change in pull request #2880: [GOBBLIN-1038] Set default dataset descriptor configs based on the DataNode
URL: https://github.com/apache/incubator-gobblin/pull/2880#discussion_r373738144
 
 

 ##########
 File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/pathfinder/AbstractPathFinder.java
 ##########
 @@ -103,6 +105,11 @@
       this.destNodes.add(destNode);
     }
 
+    // All dest nodes should be the same class
+    if (this.destNodes != null && this.destNodes.stream().map(Object::getClass).collect(Collectors.toSet()).size() > 1) {
 
 Review comment:
   Can our path finding algorithm return dest nodes with different types? just curious.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] arjun4084346 commented on issue #2880: [GOBBLIN-1038] Set default dataset descriptor configs based on the DataNode

Posted by GitBox <gi...@apache.org>.

arjun4084346 commented on issue #2880: [GOBBLIN-1038] Set default dataset descriptor configs based on the DataNode
URL: https://github.com/apache/incubator-gobblin/pull/2880#issuecomment-580965572
 
 
   +1 LGTM.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services