You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2008/01/15 19:02:44 UTC
svn commit: r612179 -
/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
Author: jleroux
Date: Tue Jan 15 10:02:30 2008
New Revision: 612179
URL: http://svn.apache.org/viewvc?rev=612179&view=rev
Log:
A 2d patch from Jeremy Wickersheimer "Process order payment doesn't check for cancelled/rejected order" (https://issues.apache.org/jira/browse/OFBIZ-1573) - OFBIZ-1573
returnFailure instead of returnSuccess : I plenty agree.
Modified:
ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java?rev=612179&r1=612178&r2=612179&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java (original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java Tue Jan 15 10:02:30 2008
@@ -3578,7 +3578,7 @@
GenericValue orderHeader = orh.getOrderHeader();
String orderStatus = orderHeader.getString("statusId");
if ("ORDER_CANCELLED".equals(orderStatus) || "ORDER_REJECTED".equals(orderStatus)) {
- return ServiceUtil.returnSuccess();
+ return ServiceUtil.returnFailure("ERROR: the Order status is "+orderStatus);
}
// process the payments