You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by André Malo <nd...@perlig.de> on 2003/11/17 01:10:37 UTC

Patch management

* Ben Collins-Sussman <su...@red-bean.com> wrote:

> FWIW:  in the Subversion project, we've assigned the hat of "patch
> manager" to a volunteer in the community.  He watches patches come in. 
> If any patch goes unanswered for a week or more, the patch manager files
> it in the issuetracker.  No more lost patches.  If anything, it makes
> the patches even more prominent -- when developers are scanning the bug
> database for a "quickie" to fix, the small patches stand out.

Yeah, I've thought about something similiar. If we don't find something else
I'm volunteering to deal with that. Messing up the bug tracker is something I
know of :-)

nd

Re: Patch management

Posted by Jeff Trawick <tr...@attglobal.net>.
Paul J. Reder wrote:

> You could have something like:
> 
> "An important benefit of Apache httpd is that you can modify the source as
> you require. While we do understand the desire to avoid re-applying patches
> to each new Apache httpd release, that ability allows users with unique
> requirements to tailor the Apache code to their own needs."

replaced, thanks!



Re: Patch management

Posted by "Paul J. Reder" <re...@remulak.net>.
The final sentence seems a bit long and confusing. Perhaps instead of:

"An important benefit of Apache httpd is that you can modify the source as
you require, and while we understand that it is preferable to avoid
re-applying patches when a new Apache httpd is released, the ability to do
so, along with providing a flexible API, is one of the ways that some users
have to tailor its behavior to match their requirements."

You could have something like:

"An important benefit of Apache httpd is that you can modify the source as
you require. While we do understand the desire to avoid re-applying patches
to each new Apache httpd release, that ability allows users with unique
requirements to tailor the Apache code to their own needs."

Jeff Trawick wrote:
> Jeff Trawick wrote:
> 
>> I'd like to write up some notes tomorrow as a draft of a new "how to 
>> submit a patch", pointing to existing info on httpd patches and 
>> describing the current bugzilla capability.
> 
> 
> With the help of Glenn (gs-apache-dev at gluelogic.com, there is a first 
> draft at http://jakarta.apache.org/~trawick/submitting_your_patch.html
> 
> This is intended to replace the section "Submitting your Patch" at
> http://httpd.apache.org/dev/patches.html.  But there is also a new 
> section that discusses what level of code can be used for creating the 
> patch.
> 
> Comments?
> 
> Thanks,
> 
> Jeff
> 
> 
> 

-- 
Paul J. Reder
-----------------------------------------------------------
"The strength of the Constitution lies entirely in the determination of each
citizen to defend it.  Only if every single citizen feels duty bound to do
his share in this defense are the constitutional rights secure."
-- Albert Einstein



Re: Patch management

Posted by Jeff Trawick <tr...@attglobal.net>.
Jeff Trawick wrote:

> I'd like to write up some notes tomorrow as a draft of a new "how to 
> submit a patch", pointing to existing info on httpd patches and 
> describing the current bugzilla capability.

With the help of Glenn (gs-apache-dev at gluelogic.com, there is a first draft 
at http://jakarta.apache.org/~trawick/submitting_your_patch.html

This is intended to replace the section "Submitting your Patch" at
http://httpd.apache.org/dev/patches.html.  But there is also a new section that 
discusses what level of code can be used for creating the patch.

Comments?

Thanks,

Jeff



Re: Patch management

Posted by Jeff Trawick <tr...@attglobal.net>.
Joshua Slive wrote:

> On Mon, 17 Nov 2003, Jeff Trawick wrote:
> 
>>What must be done to the bug tracker we have now to track the patches better?
>>
>>(I'm not against having something better, but I don't want to see a delay in
>>waiting for some magic tool.)
>>
>>We can already assign the keyword "PatchAvailable" for entries and mark entries
>>as enhancements or bugs of various severities.  People with patches to submit
>>can already manage the data entry themselves.
> 
> 
> I did try to use the PatchAvailable keyword for a while.  I even posted
> helpful links like this to the dev list:
> http://nagoya.apache.org/bugzilla/buglist.cgi?bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&product=Apache+httpd-1.3&product=Apache+httpd-2.0&keywords=PatchAvailable&keywords_type=anywords

Hopefully there is a way to query these entries that haven't been modified in a 
while.

> I'm sure the people who skim the bug database traffic wouldn't mind making
> sure that keyword gets assigned.

and also we need to make sure that random patches that show up on dev@ end up 
being entered in bugzilla with a patch in the correct format.

The patch manager doesn't necessarily have to do all the work of getting 
patches documented in the right place.  S/he just has to make sure that 
somebody does it for every patch submitted during her/his tour of duty.

Hopefully there is more awareness of the problem of dropped patches now than 
there was when you pointed out the PatchAvailable use before.

> The biggest problem is:
> 
>>b) making sure the submitter gets some response in a reasonable time
> 
> Perhaps one thing to do would be to more strongly encourage people, as an
> entry to apache development, to go through these PatchAvailable bugs, and
> do formal reviews and tests of the code.  Of course a core team member
> needs to do the final commit, but it is easier if there is evidence of
> reviews.

that would definitely help...  I'm anxious to see what the response would be... 
  surely we have some generic doc on what people can do to help out with httpd 
development that we can point to on the list periodically?  or pay a spammer to 
let all our users know?

I'd like to write up some notes tomorrow as a draft of a new "how to submit a 
patch", pointing to existing info on httpd patches and describing the current 
bugzilla capability.  Once we have something to point people to so we don't 
have to keep explaining the process and so they don't have to look in too many 
different places for all the info, I'd like to play patch manager for a while. 
  This will die out as surely as your previous PatchAvailable attempts if 
nobody else lifts a finger, but I'm ever hopeful :)



Re: Patch management

Posted by Joshua Slive <jo...@slive.ca>.
On Mon, 17 Nov 2003, Jeff Trawick wrote:
> What must be done to the bug tracker we have now to track the patches better?
>
> (I'm not against having something better, but I don't want to see a delay in
> waiting for some magic tool.)
>
> We can already assign the keyword "PatchAvailable" for entries and mark entries
> as enhancements or bugs of various severities.  People with patches to submit
> can already manage the data entry themselves.

I did try to use the PatchAvailable keyword for a while.  I even posted
helpful links like this to the dev list:
http://nagoya.apache.org/bugzilla/buglist.cgi?bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&product=Apache+httpd-1.3&product=Apache+httpd-2.0&keywords=PatchAvailable&keywords_type=anywords

I'm sure the people who skim the bug database traffic wouldn't mind making
sure that keyword gets assigned.

The biggest problem is:

> b) making sure the submitter gets some response in a reasonable time

Perhaps one thing to do would be to more strongly encourage people, as an
entry to apache development, to go through these PatchAvailable bugs, and
do formal reviews and tests of the code.  Of course a core team member
needs to do the final commit, but it is easier if there is evidence of
reviews.

Joshua.

Re: Patch management

Posted by Stas Bekman <st...@stason.org>.
Jeff Trawick wrote:
> Stas Bekman wrote:
> 
>> Jeff Trawick wrote:
>>
>>> - make sure that the PR # is in the subject of any on-list discussion 
>>> of the patch
>>
>>
>>
>> Why not automate this process. Change bugzilla to do the job and 
>> autogenerate the right link:
>>
>> <a 
>> hred="mailto:dev@httpd.apache.org?Subject=[PATCH%20PR%20#12345]">Post 
>> the patch to the httpd-dev list]</a>
> 
> 
> In that bullet ("make sure that the PR #") I just wanted to point out 
> that IFF the submitter has something technical to discuss on dev@ or 
> wants to try to get support for the concept on dev@, at least make sure 
> the subject line mentions the bugzilla entry.  While it is more natural 
> to have a discussion on dev@ than via bugzilla, I think we should 
> optimize for the people willing to go query bugzilla and see what 
> patches are unresolved.  Right now, that means keep as much discussion 
> as possible in bugzilla.

Which will prevent from most people to see the discussions at a timely manner. 
You should really look at RT which gives you the best of the both worlds.

In any case, my suggestion was to make easier for users generate the correct 
subjects and not to automatically generate an email here, but just a link.

> It would be great to autogenerate a dev@ post when the PatchAvailable 
> keyword is added in order to give awareness to everybody.  The subject 
> would be "[PATCH PR #12345] <bugzilla summary>" and the body would be 
> the URL of the entry.  And if the submitter wishes to discuss on the 
> list, they can respond to that post.  I just don't think we have to post 
> the patch itself, or imply with the button that the patch needs to be 
> submitted in two places.

For the same reason we ask people to inline the patches when posting to the 
list, and not attach them (easier to comment on in reply and doesn't require 
special steps in order to view the patch), I think that on the opposite the 
patch should be inlined and a pointer to the original patch posted along, in 
case the patch included tabs or some other chars that may not survive inlining.

[...]
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


Re: Patch management

Posted by Jeff Trawick <tr...@attglobal.net>.
Stas Bekman wrote:

> Jeff Trawick wrote:
> 
>> - make sure that the PR # is in the subject of any on-list discussion 
>> of the patch
> 
> 
> Why not automate this process. Change bugzilla to do the job and 
> autogenerate the right link:
> 
> <a hred="mailto:dev@httpd.apache.org?Subject=[PATCH%20PR%20#12345]">Post 
> the patch to the httpd-dev list]</a>

In that bullet ("make sure that the PR #") I just wanted to point out that IFF 
the submitter has something technical to discuss on dev@ or wants to try to get 
support for the concept on dev@, at least make sure the subject line mentions 
the bugzilla entry.  While it is more natural to have a discussion on dev@ than 
via bugzilla, I think we should optimize for the people willing to go query 
bugzilla and see what patches are unresolved.  Right now, that means keep as 
much discussion as possible in bugzilla.

It would be great to autogenerate a dev@ post when the PatchAvailable keyword 
is added in order to give awareness to everybody.  The subject would be "[PATCH 
PR #12345] <bugzilla summary>" and the body would be the URL of the entry.  And 
if the submitter wishes to discuss on the list, they can respond to that post. 
  I just don't think we have to post the patch itself, or imply with the button 
that the patch needs to be submitted in two places.

<warning>
I'm not about to mess with Bugzilla or RT or anything else.  Whoever is willing 
can pretty much make it work the way they want to and I will go along, in 
exchange for having more time to work directly on Apache.  Heck, even Gnats 
didn't upset me.  The process is not set in stone and is expected to be 
continually improved.  I just didn't want to wait for something more perfect.
</warning>

> The cool thing about RT is that it does all this for you and all 
> discussions at the list are "blogged" into the bug record.

That sounds like a huge improvement.



Re: Patch management

Posted by Stas Bekman <st...@stason.org>.
Jeff Trawick wrote:

It's great to see that things are happening, Jeff!

> The people issues are at least:
> 
> a) making sure patches submitted on the mailing list are in the db, by 
> prodding the submitter to consult some on-line doc that describes the 
> requirements for submitting a patch
> 
> - get the style correct
> - use the right diff flavor
> - explain how to reproduce the problem and how the patch has been tested
> - go to nagoya.apache.org and submit the patch as a PR, not forgetting 
> to flag the entry with PatchAvailable
> - make sure that the PR # is in the subject of any on-list discussion of 
> the patch

Why not automate this process. Change bugzilla to do the job and autogenerate 
the right link:

<a hred="mailto:dev@httpd.apache.org?Subject=[PATCH%20PR%20#12345]">Post the 
patch to the httpd-dev list]</a>

The cool thing about RT is that it does all this for you and all discussions 
at the list are "blogged" into the bug record.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


Re: Patch management

Posted by Jeff Trawick <tr...@attglobal.net>.
André Malo wrote:

> * Ben Collins-Sussman <su...@red-bean.com> wrote:
> 
> 
>>FWIW:  in the Subversion project, we've assigned the hat of "patch
>>manager" to a volunteer in the community.  He watches patches come in. 
>>If any patch goes unanswered for a week or more, the patch manager files
>>it in the issuetracker.  No more lost patches.  If anything, it makes
>>the patches even more prominent -- when developers are scanning the bug
>>database for a "quickie" to fix, the small patches stand out.
> 
> 
> Yeah, I've thought about something similiar. If we don't find something else
> I'm volunteering to deal with that. Messing up the bug tracker is something I
> know of :-)

What must be done to the bug tracker we have now to track the patches better?

(I'm not against having something better, but I don't want to see a delay in 
waiting for some magic tool.)

We can already assign the keyword "PatchAvailable" for entries and mark entries 
as enhancements or bugs of various severities.  People with patches to submit 
can already manage the data entry themselves.

The people issues are at least:

a) making sure patches submitted on the mailing list are in the db, by prodding 
the submitter to consult some on-line doc that describes the requirements for 
submitting a patch

- get the style correct
- use the right diff flavor
- explain how to reproduce the problem and how the patch has been tested
- go to nagoya.apache.org and submit the patch as a PR, not forgetting to flag 
the entry with PatchAvailable
- make sure that the PR # is in the subject of any on-list discussion of the patch
- remind people that they have the source and can modify the server however 
they want and that it isn't the worst thing in the world if they have to 
continually apply the patch locally if it isn't accepted for some reason

b) making sure the submitter gets some response in a reasonable time

the submitter needs a response within a week giving some initial status so s/he 
knows it isn't quite a black hole

we need to be able to query this, so that the patch manager can regularly query 
for patches that have no response, and then make sure the submitter knows the 
status (this is the time to catch procedural errors in the submission)

c) trying to focus some attention on patches in limbo

perhaps getting 3+ people on IRC for an hour every week or so to look through 
current patches and see make some quick decisions on as many patches-in-limbo 
as possible