You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nuttx.apache.org by Pierre-Noel Bouteville <pn...@gmail.com> on 2023/02/11 11:35:43 UTC

Bug? in stm32_sdio.c

Hi,

Sorry I haven't time to made a pull request for a little possible bug.

in boards/arm/stm32/stm32_sdio.c line 1792 there is a return so value is 
not apply in register.

Re: Bug? in stm32_sdio.c

Posted by Pierre-Noel Bouteville <pn...@hotmail.com>.

Thanks i will test as soon as possible. I’m on other project with SD CARD but without os so I found it with review of code ;) 

Envoyé de mon iPhone

> Le 11 févr. 2023 à 21:28, Fotis Panagiotopoulos <f....@gmail.com> a écrit :
> 
> Hello,
> 
> A fix has already been merged.
> 
> https://github.com/apache/nuttx/pull/8502
> 
>> On Sat, Feb 11, 2023 at 9:48 PM Alan C. Assis <ac...@gmail.com> wrote:
>> 
>> Hi Pierre-Noel,
>> 
>> Good catch! Although the right file is
>> arch/arm/src/stm32/stm32_sdio.c, not boards/...
>> 
>> This file has this possible BUG since when it was added into NuttX and
>> it works as you can see here:
>> 
>> https://www.youtube.com/watch?v=H28t4RbOXqI
>> 
>> Probably someone using SDIO for other applications (like to use with
>> WiFi chips) could face some issue when trying to disable the SDIO.
>> 
>> Please send the PR or case you don't have time to do it, I could
>> submit it and put you as author.
>> 
>> BR,
>> 
>> Alan
>> 
>>> On 2/11/23, Pierre-Noel Bouteville <pn...@gmail.com> wrote:
>>> Hi,
>>> 
>>> Sorry I haven't time to made a pull request for a little possible bug.
>>> 
>>> in boards/arm/stm32/stm32_sdio.c line 1792 there is a return so value is
>>> not apply in register.
>>> 
>>

Re: Bug? in stm32_sdio.c

Posted by Fotis Panagiotopoulos <f....@gmail.com>.

Hello,

A fix has already been merged.

https://github.com/apache/nuttx/pull/8502

On Sat, Feb 11, 2023 at 9:48 PM Alan C. Assis <ac...@gmail.com> wrote:

> Hi Pierre-Noel,
>
> Good catch! Although the right file is
> arch/arm/src/stm32/stm32_sdio.c, not boards/...
>
> This file has this possible BUG since when it was added into NuttX and
> it works as you can see here:
>
> https://www.youtube.com/watch?v=H28t4RbOXqI
>
> Probably someone using SDIO for other applications (like to use with
> WiFi chips) could face some issue when trying to disable the SDIO.
>
> Please send the PR or case you don't have time to do it, I could
> submit it and put you as author.
>
> BR,
>
> Alan
>
> On 2/11/23, Pierre-Noel Bouteville <pn...@gmail.com> wrote:
> > Hi,
> >
> > Sorry I haven't time to made a pull request for a little possible bug.
> >
> > in boards/arm/stm32/stm32_sdio.c line 1792 there is a return so value is
> > not apply in register.
> >
>

Re: Bug? in stm32_sdio.c

Posted by "Alan C. Assis" <ac...@gmail.com>.

Hi Pierre-Noel,

Good catch! Although the right file is
arch/arm/src/stm32/stm32_sdio.c, not boards/...

This file has this possible BUG since when it was added into NuttX and
it works as you can see here:

https://www.youtube.com/watch?v=H28t4RbOXqI

Probably someone using SDIO for other applications (like to use with
WiFi chips) could face some issue when trying to disable the SDIO.

Please send the PR or case you don't have time to do it, I could
submit it and put you as author.

BR,

Alan

On 2/11/23, Pierre-Noel Bouteville <pn...@gmail.com> wrote:
> Hi,
>
> Sorry I haven't time to made a pull request for a little possible bug.
>
> in boards/arm/stm32/stm32_sdio.c line 1792 there is a return so value is
> not apply in register.
>