You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@groovy.apache.org by Jochen Theodorou <bl...@gmx.org> on 2017/12/24 14:07:35 UTC
Why no asm6 on Groovy2.4.x?
Hi all,
Why do we currently not use asm 6.0 for Groovy 2.4.x? We do for master
at least.
bye Jochen
Re: Why no asm6 on Groovy2.4.x?
Posted by Daniel Sun <re...@hotmail.com>.
Hi Jochen,
I've updated the dependency, it should work now. Let's wait to see the
result of build:
http://ci.groovy-lang.org/viewLog.html?buildId=45797&tab=buildResultsDiv&buildTypeId=Groovy_Jdk8BuildWithSnapshotDeploy24x
Cheers,
Daniel.Sun
--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Re: Why no asm6 on Groovy2.4.x?
Posted by Cédric Champeau <ce...@gmail.com>.
FTR it's pretty easy to find out what brings the faulty dependency by
accessing the build scan:
https://scans.gradle.com/s/lz5mbozdytxtc/dependencies?dependencies=asm-all&expandAll
2017-12-26 10:45 GMT+01:00 Jochen Theodorou <bl...@gmx.org>:
> On 26.12.2017 00:54, Daniel.Sun wrote:
>
>> Hi Jochen,
>>
>> It seems that Groovy does not rely on asm-all:
>> https://github.com/apache/groovy/blob/e9b6bddda05165195db24d
>> 42ed3715e4752e0397/build.gradle#L178-L182
>>
>
> something seems to
>
> In addition, the asm's jar files can be downloaded properly(I could
>> not find "Gradle failure report"):
>> https://travis-ci.org/apache/groovy/jobs/321192018#L586-L596
>>
>> Could you show me the link to the error messages?
>>
>
> See http://ci.groovy-lang.org/viewLog.html?buildId=45781&buildTy
> peId=Groovy_Jdk8BuildWithSnapshotDeploy24x&tab=buildLog#_
> state=80420,80433&focus=80433
> failure is during :groidjar
>
> bye Jochen
>
Re: Why no asm6 on Groovy2.4.x?
Posted by Jochen Theodorou <bl...@gmx.org>.
On 26.12.2017 00:54, Daniel.Sun wrote:
> Hi Jochen,
>
> It seems that Groovy does not rely on asm-all:
> https://github.com/apache/groovy/blob/e9b6bddda05165195db24d42ed3715e4752e0397/build.gradle#L178-L182
something seems to
> In addition, the asm's jar files can be downloaded properly(I could
> not find "Gradle failure report"):
> https://travis-ci.org/apache/groovy/jobs/321192018#L586-L596
>
> Could you show me the link to the error messages?
See
http://ci.groovy-lang.org/viewLog.html?buildId=45781&buildTypeId=Groovy_Jdk8BuildWithSnapshotDeploy24x&tab=buildLog#_state=80420,80433&focus=80433
failure is during :groidjar
bye Jochen
Re: Why no asm6 on Groovy2.4.x?
Posted by Remi Forax <fo...@univ-mlv.fr>.
yes,
when some dependencies are using asm-all and some are not, with the classpath, it was working after sacrificing a goat, it does not work with modules so we have retired this artifact.
Happy Christmas,
Rémi
> De: "Cédric Champeau" <ce...@gmail.com>
> À: "dev" <de...@groovy.apache.org>
> Cc: "dev" <de...@groovy.incubator.apache.org>
> Envoyé: Mardi 26 Décembre 2017 08:36:28
> Objet: Re: Why no asm6 on Groovy2.4.x?
> There's no such thing as asm-all. Just like us, they had to get rid of their
> "all" artifact in 6.0. So we have to use the normal version.
> Le 26 déc. 2017 00:54, "Daniel.Sun" < [ mailto:sunlan@apache.org |
> sunlan@apache.org ] > a écrit :
>> Hi Jochen,
>> It seems that Groovy does not rely on asm-all:
>> [
>> https://github.com/apache/groovy/blob/e9b6bddda05165195db24d42ed3715e4752e0397/build.gradle#L178-L182
>> |
>> https://github.com/apache/groovy/blob/e9b6bddda05165195db24d42ed3715e4752e0397/build.gradle#L178-L182
>> ]
>> In addition, the asm's jar files can be downloaded properly(I could
>> not find "Gradle failure report"):
>> [ https://travis-ci.org/apache/groovy/jobs/321192018#L586-L596 |
>> https://travis-ci.org/apache/groovy/jobs/321192018#L586-L596 ]
>> Could you show me the link to the error messages?
>> Cheers,
>> Daniel.Sun
>> --
>> Sent from: [ http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html |
>> http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html ]
Re: Why no asm6 on Groovy2.4.x?
Posted by Cédric Champeau <ce...@gmail.com>.
There's no such thing as asm-all. Just like us, they had to get rid of
their "all" artifact in 6.0. So we have to use the normal version.
Le 26 déc. 2017 00:54, "Daniel.Sun" <su...@apache.org> a écrit :
> Hi Jochen,
>
> It seems that Groovy does not rely on asm-all:
> https://github.com/apache/groovy/blob/e9b6bddda05165195db24d42ed3715
> e4752e0397/build.gradle#L178-L182
>
> In addition, the asm's jar files can be downloaded properly(I could
> not find "Gradle failure report"):
> https://travis-ci.org/apache/groovy/jobs/321192018#L586-L596
>
> Could you show me the link to the error messages?
>
> Cheers,
> Daniel.Sun
>
>
>
> --
> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
>
Re: Why no asm6 on Groovy2.4.x?
Posted by "Daniel.Sun" <su...@apache.org>.
Hi Jochen,
It seems that Groovy does not rely on asm-all:
https://github.com/apache/groovy/blob/e9b6bddda05165195db24d42ed3715e4752e0397/build.gradle#L178-L182
In addition, the asm's jar files can be downloaded properly(I could
not find "Gradle failure report"):
https://travis-ci.org/apache/groovy/jobs/321192018#L586-L596
Could you show me the link to the error messages?
Cheers,
Daniel.Sun
--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Re: Why no asm6 on Groovy2.4.x?
Posted by Jochen Theodorou <bl...@gmx.org>.
On 25.12.2017 02:26, Daniel.Sun wrote:
> The version of ASM has upgraded to 6.0 :-)
>
> https://github.com/apache/groovy/commit/091e178495a5dbd44ab46374121b7f28ea98d6d1
that fixed the JDK6 build and together with your other fix we have now
fixed all builds, but one:
> [02:13:02][Gradle failure report] Caused by: org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find org.ow2.asm:asm-all:6.0.
> [02:13:02][Gradle failure report] Searched in the following locations:
> [02:13:02][Gradle failure report] https://jcenter.bintray.com/org/ow2/asm/asm-all/6.0/asm-all-6.0.pom
> [02:13:02][Gradle failure report] https://jcenter.bintray.com/org/ow2/asm/asm-all/6.0/asm-all-6.0.jar
> [02:13:02][Gradle failure report] http://dl.bintray.com/melix/thirdparty-apache/org/ow2/asm/asm-all/6.0/asm-all-6.0.pom
> [02:13:02][Gradle failure report] http://dl.bintray.com/melix/thirdparty-apache/org/ow2/asm/asm-all/6.0/asm-all-6.0.jar
> [02:13:02][Gradle failure report] http://repository.jboss.org/nexus/content/groups/m2-release-proxy/org/ow2/asm/asm-all/6.0/asm-all-6.0.pom
> [02:13:02][Gradle failure report] http://repository.jboss.org/nexus/content/groups/m2-release-proxy/org/ow2/asm/asm-all/6.0/asm-all-6.0.jar
> [02:13:02][Gradle failure report] https://oss.jfrog.org/libs-release/org/ow2/asm/asm-all/6.0/asm-all-6.0.pom
> [02:13:02][Gradle failure report] https://oss.jfrog.org/libs-release/org/ow2/asm/asm-all/6.0/asm-all-6.0.jar
> [02:13:02][Gradle failure report] Required by:
> [02:13:02][Gradle failure report] org.codehaus.groovy:groovy:2.4.14-SNAPSHOT
And it seems there is really no asm-all for asm 6.... but then, how can
the jdk7 build work for that branch?
bye Jochen
Re: Why no asm6 on Groovy2.4.x?
Posted by "Daniel.Sun" <su...@apache.org>.
The version of ASM has upgraded to 6.0 :-)
https://github.com/apache/groovy/commit/091e178495a5dbd44ab46374121b7f28ea98d6d1
Cheers,
Daniel.Sun
--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Re: Why no asm6 on Groovy2.4.x?
Posted by "Daniel.Sun" <su...@apache.org>.
Hi Jochen,
I'm trying to upgrade asm on my fork[1], let's wait to see the result
of build ;-)
Cheers,
Daniel.Sun
[1]
https://travis-ci.org/danielsun1106/groovy/builds/321181232?utm_source=github_status&utm_medium=notification
--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html