You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2011/04/01 01:40:05 UTC

[jira] [Resolved] (NET-397) FTPSClient does not handle AUTH or ADAT and only partially handles PBSZ. FTPSCommand should be deprecated

     [ https://issues.apache.org/jira/browse/NET-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved NET-397.
----------------------

       Resolution: Fixed
    Fix Version/s: 3.0

Applied patch with a few changes. Moved isProtectedReplyCode() to FTPReply class; made public constants private as users should not be encouraged to issue the commands directly.
Had to keep sendCommand() override for backward compat, which means execCCC now delegates to it (via FTP class)
Added parsePBSZ method to handle PBSZ reply.

> FTPSClient does not handle AUTH or ADAT and only partially handles PBSZ. FTPSCommand should be deprecated 
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: NET-397
>                 URL: https://issues.apache.org/jira/browse/NET-397
>             Project: Commons Net
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 3.0
>
>         Attachments: ftps-rfc2228.diff
>
>
> FTPSClient does not provide any code to handle AUTH or ADAT, and does not provide support for handling a reduced buffer size provided by the server.
> FTPSCommand defines int values for AUTH and ADAT, but if the integer values are used by client code, the value will be passed to FTPClient, which uses its own array of command strings, and FTPSCommand.AUTH will translate to "USER" and ADAT => "PASS", similarly for PBSZ, PROT and CCC.
> These commands all need special handling, so should be dealt with by FTPSClient only.
> FTPSClient can override the sendCommand(int) and sendCommand(int, String) methods in FTPClient which will help prevent problems.
> Since most of these commands need additional special handling, there should be execNAME() methods for each.
> FTPSCommand should be deprecated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira