You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/10/24 16:01:09 UTC
[GitHub] [hudi] lw309637554 opened a new pull request #2205: [HUDI-1118] Cleanup rollback files residing in .hoodie folder
lw309637554 opened a new pull request #2205:
URL: https://github.com/apache/hudi/pull/2205
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
Cleanup rollback files residing in .hoodie folder
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #2205: [HUDI-1118] Cleanup rollback files residing in .hoodie folder
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2205:
URL: https://github.com/apache/hudi/pull/2205#issuecomment-715983082
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2205?src=pr&el=h1) Report
> Merging [#2205](https://codecov.io/gh/apache/hudi/pull/2205?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/14c4611857ea796b8d3aef96f867db9cd0ae31f7?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/2205?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2205 +/- ##
=========================================
Coverage 53.68% 53.68%
Complexity 2849 2849
=========================================
Files 359 359
Lines 16565 16565
Branches 1782 1782
=========================================
Hits 8893 8893
Misses 6915 6915
Partials 757 757
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #hudicli | `38.37% <ø> (ø)` | `193.00 <ø> (ø)` | |
| #hudiclient | `100.00% <ø> (ø)` | `0.00 <ø> (ø)` | |
| #hudicommon | `54.70% <ø> (ø)` | `1794.00 <ø> (ø)` | |
| #hudihadoopmr | `33.05% <ø> (ø)` | `181.00 <ø> (ø)` | |
| #hudispark | `65.95% <ø> (ø)` | `304.00 <ø> (ø)` | |
| #huditimelineservice | `62.29% <ø> (ø)` | `50.00 <ø> (ø)` | |
| #hudiutilities | `70.09% <ø> (ø)` | `327.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io commented on pull request #2205: [HUDI-1118] Cleanup rollback files residing in .hoodie folder
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2205:
URL: https://github.com/apache/hudi/pull/2205#issuecomment-715983082
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2205?src=pr&el=h1) Report
> Merging [#2205](https://codecov.io/gh/apache/hudi/pull/2205?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/14c4611857ea796b8d3aef96f867db9cd0ae31f7?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/2205?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2205 +/- ##
=========================================
Coverage 53.68% 53.68%
Complexity 2849 2849
=========================================
Files 359 359
Lines 16565 16565
Branches 1782 1782
=========================================
Hits 8893 8893
Misses 6915 6915
Partials 757 757
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #hudicli | `38.37% <ø> (ø)` | `193.00 <ø> (ø)` | |
| #hudiclient | `100.00% <ø> (ø)` | `0.00 <ø> (ø)` | |
| #hudicommon | `54.70% <ø> (ø)` | `1794.00 <ø> (ø)` | |
| #hudihadoopmr | `33.05% <ø> (ø)` | `181.00 <ø> (ø)` | |
| #hudispark | `65.95% <ø> (ø)` | `304.00 <ø> (ø)` | |
| #huditimelineservice | `62.29% <ø> (ø)` | `50.00 <ø> (ø)` | |
| #hudiutilities | `70.09% <ø> (ø)` | `327.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #2205: [HUDI-1118] Cleanup rollback files residing in .hoodie folder
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #2205:
URL: https://github.com/apache/hudi/pull/2205#issuecomment-716057045
@n3nash can you please take a pass at this. since we had some reason to exclude rollback back then? do you recall why
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash merged pull request #2205: [HUDI-1118] Cleanup rollback files residing in .hoodie folder
Posted by GitBox <gi...@apache.org>.
n3nash merged pull request #2205:
URL: https://github.com/apache/hudi/pull/2205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] lw309637554 commented on pull request #2205: [HUDI-1118] Cleanup rollback files residing in .hoodie folder
Posted by GitBox <gi...@apache.org>.
lw309637554 commented on pull request #2205:
URL: https://github.com/apache/hudi/pull/2205#issuecomment-716079397
> @n3nash can you please take a pass at this. since we had some reason to exclude rollback back then? do you recall why
@vinothchandar @n3nash i have some background .
1. before https://github.com/apache/hudi/pull/1756/files have the comment
// TODO: Handle ROLLBACK_ACTION in future
// ROLLBACK_ACTION is currently not defined in HoodieActiveTimeline
2. but i see ROLLBACK_ACTION define already in HoodieActiveTimeline. so we can add ROLLBACK_ACTION in archivelog
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash commented on pull request #2205: [HUDI-1118] Cleanup rollback files residing in .hoodie folder
Posted by GitBox <gi...@apache.org>.
n3nash commented on pull request #2205:
URL: https://github.com/apache/hudi/pull/2205#issuecomment-716290307
@vinothchandar the reason is basically what @lw309637554 mentioned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org