You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/03/01 05:58:40 UTC
[GitHub] [camel-k] tadayosi opened a new pull request #3051: fix(lint): temporarily disable nolintlint to suppress false alarm in CI
tadayosi opened a new pull request #3051:
URL: https://github.com/apache/camel-k/pull/3051
<!-- Description -->
Let's temporarily disable `nolintlint` to suppress the annoying false alarm in validate CI:
```
Error: directive `// nolint: staticcheck` is unused for linter "staticcheck" (nolintlint)
```
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi closed pull request #3051: fix(lint): temporarily disable nolintlint to suppress false alarm in CI
Posted by GitBox <gi...@apache.org>.
tadayosi closed pull request #3051:
URL: https://github.com/apache/camel-k/pull/3051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3051: fix(lint): temporarily disable nolintlint to suppress false alarm in CI
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #3051:
URL: https://github.com/apache/camel-k/pull/3051#issuecomment-1055675507
The validate looks good now after merging that PR, see https://github.com/apache/camel-k/runs/5378964970?check_suite_focus=true I think you can close this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3051: fix(lint): temporarily disable nolintlint to suppress false alarm in CI
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #3051:
URL: https://github.com/apache/camel-k/pull/3051#issuecomment-1060334208
@tadayosi I think you can update this PR by removing the last commit and keeping the aab73b6fc44a8b27eb33904610a0c07c8c3f6224 commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3051: fix(lint): temporarily disable nolintlint to suppress false alarm in CI
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #3051:
URL: https://github.com/apache/camel-k/pull/3051#issuecomment-1055172653
> @squakez Sure. I wasn't aware it's being fixed already. Glad we don't need this one.
Yeah, let's keep this open anyway, as sometimes it does not fail in the PR but it fails later in the merge. I'll have a look later in the day to see how it goes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez edited a comment on pull request #3051: fix(lint): temporarily disable nolintlint to suppress false alarm in CI
Posted by GitBox <gi...@apache.org>.
squakez edited a comment on pull request #3051:
URL: https://github.com/apache/camel-k/pull/3051#issuecomment-1055675507
The validate looks good now after merging that PR, see https://github.com/apache/camel-k/runs/5378964970?check_suite_focus=true
I think you can still keep the first commit of this PR as it is a good enhancement to have the list of lints sorted alphabeticallly though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3051: fix(lint): temporarily disable nolintlint to suppress false alarm in CI
Posted by GitBox <gi...@apache.org>.
tadayosi commented on pull request #3051:
URL: https://github.com/apache/camel-k/pull/3051#issuecomment-1055169607
@squakez Sure. I wasn't aware it's being fixed already. Glad we don't need this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3051: fix(lint): temporarily disable nolintlint to suppress false alarm in CI
Posted by GitBox <gi...@apache.org>.
tadayosi commented on pull request #3051:
URL: https://github.com/apache/camel-k/pull/3051#issuecomment-1060462310
@squakez Thanks. I've gone ahead and merged the list sorting part already. I'm closing this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org