You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Jochen Wiedmann <jo...@gmail.com> on 2008/01/18 22:46:04 UTC
[VOTE] Release commons-fileupload 1.2.1 (rc4)
Hi,
I have prepared a release candidate 4 of commons-fileupload
1.2.1. The SVN tag is commons-fileupload-1.2.1rc4. A list of
changes since rc3 and things that I haven't changes,
can be found below.
As usual, the proposed distributables can be found on
http://people.apache.org/~jochen/commons-fileupload/dist
The proposed site (unchanged since rc3) is on
http://people.apache.org/~jochen/commons-fileupload/site
Thanks,
Jochen
[ ] +1
[ ] =0
[ ] -1
Changes since 1.2.1rc3:
- Upgraded commons-parent to version 7. This means, in particular,
that the maven-remote-resources-plugin is no longer used.
- MD5 and SHA1 checksums now have the binary flag (*)
- Fixed the copyright in the Javadoc bottom
- Building with Ant and Java 1.3.1 works again.
Other comments:
> What does "(optional)" mean in the Dependencies section under Commons IO?
It means optional. Commons-IO is required only, if you intend to use
the DiskFileItem.
> What commands are needed to build and test the code?
The same than for most other commons projects:
ant
maven build
mvn install
Choose what you prefer.
> I could not find the information on the site.
May be. However, if that is the case, then it was the same for at
least the previous two releases and it wasn't a blocking issue at the
time.
> Also, build.xml seems to be out of date, as it refers to junit 3.8.1.
I don't think this is a problem.
--
Look, that's why there's rules, understand? So that you think before
you break 'em.
-- (Terry Pratchett, Thief of Time)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release commons-fileupload 1.2.1 (rc4)
Posted by Niall Pemberton <ni...@gmail.com>.
+1
Niall
On Jan 18, 2008 9:46 PM, Jochen Wiedmann <jo...@gmail.com> wrote:
> Hi,
>
> I have prepared a release candidate 4 of commons-fileupload
> 1.2.1. The SVN tag is commons-fileupload-1.2.1rc4. A list of
> changes since rc3 and things that I haven't changes,
> can be found below.
>
> As usual, the proposed distributables can be found on
>
> http://people.apache.org/~jochen/commons-fileupload/dist
>
> The proposed site (unchanged since rc3) is on
>
> http://people.apache.org/~jochen/commons-fileupload/site
>
>
> Thanks,
>
> Jochen
>
>
> [ ] +1
> [ ] =0
> [ ] -1
>
>
> Changes since 1.2.1rc3:
>
> - Upgraded commons-parent to version 7. This means, in particular,
> that the maven-remote-resources-plugin is no longer used.
> - MD5 and SHA1 checksums now have the binary flag (*)
> - Fixed the copyright in the Javadoc bottom
> - Building with Ant and Java 1.3.1 works again.
>
> Other comments:
>
> > What does "(optional)" mean in the Dependencies section under Commons IO?
>
> It means optional. Commons-IO is required only, if you intend to use
> the DiskFileItem.
>
>
> > What commands are needed to build and test the code?
>
> The same than for most other commons projects:
>
> ant
> maven build
> mvn install
>
> Choose what you prefer.
>
> > I could not find the information on the site.
>
> May be. However, if that is the case, then it was the same for at
> least the previous two releases and it wasn't a blocking issue at the
> time.
>
> > Also, build.xml seems to be out of date, as it refers to junit 3.8.1.
>
> I don't think this is a problem.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release commons-fileupload 1.2.1 (rc4)
Posted by sebb <se...@gmail.com>.
On 19/01/2008, Oliver Heger <ol...@oliver-heger.de> wrote:
> +1
>
> The build works for me in all variants as expected (on JDK 1.6). The
> only minor nit I have is that the Copyright in the Javadocs still looks
> a bit wired (at least on my browser): Instead of the Copyright character
> I only get a "?".
>
Me too when I look at e.g.:
http://people.apache.org/~jochen/commons-fileupload/site/apidocs/index.html
or perhaps that was not regenerated?
In the API docs generated by the Ant build, there is no Copyright footer at all.
"maven dist" creates the Javadoc with OK Copyright symbols, but as
mentioned before it fails before creating the archives.
Not sure what M2 goal(s) correspond with M1 dist, but
mvn package site:site assembly:assembly
did seem to create the Javadocs with the correct copyright before failing with:
[INFO] Unable to find information in class
org.apache.commons.fileupload.FileUploadBase referring back to nested
class org.apache.co
mmons.fileupload.FileUploadBase$1
[INFO] ------------------------------------------------------------------------
[INFO] Trace
net.sf.clirr.core.CheckerException: Unable to find information in
class org.apache.commons.fileupload.FileUploadBase referring back
to nested class org.apache.commons.fileupload.FileUploadBase$1
at net.sf.clirr.core.internal.bcel.BcelScopeHelper.getClassScope(BcelScopeHelper.java:127)
at net.sf.clirr.core.internal.bcel.BcelJavaType.getDeclaredScope(BcelJavaType.java:141)
at net.sf.clirr.core.internal.bcel.BcelJavaType.getEffectiveScope(BcelJavaType.java:145)
at net.sf.clirr.core.Checker.runClassChecks(Checker.java:156)
at net.sf.clirr.core.Checker.reportDiffs(Checker.java:136)
at org.codehaus.mojo.clirr.AbstractClirrMojo.executeClirr(AbstractClirrMojo.java:227)
at org.codehaus.mojo.clirr.ClirrReport.doReport(ClirrReport.java:249)
<snip/>
Presumably I used the wrong M2 goals.
What goal(s) are needed to create the site and archives?
> Oliver
>
> Jochen Wiedmann schrieb:
> > Hi,
> >
> > I have prepared a release candidate 4 of commons-fileupload
> > 1.2.1. The SVN tag is commons-fileupload-1.2.1rc4. A list of
> > changes since rc3 and things that I haven't changes,
> > can be found below.
> >
> > As usual, the proposed distributables can be found on
> >
> > http://people.apache.org/~jochen/commons-fileupload/dist
> >
> > The proposed site (unchanged since rc3) is on
> >
> > http://people.apache.org/~jochen/commons-fileupload/site
> >
> >
> > Thanks,
> >
> > Jochen
> >
> >
> > [ ] +1
> > [ ] =0
> > [ ] -1
> >
> >
> > Changes since 1.2.1rc3:
> >
> > - Upgraded commons-parent to version 7. This means, in particular,
> > that the maven-remote-resources-plugin is no longer used.
> > - MD5 and SHA1 checksums now have the binary flag (*)
> > - Fixed the copyright in the Javadoc bottom
> > - Building with Ant and Java 1.3.1 works again.
> >
> > Other comments:
> >
> >> What does "(optional)" mean in the Dependencies section under Commons IO?
> >
> > It means optional. Commons-IO is required only, if you intend to use
> > the DiskFileItem.
> >
> >
> >> What commands are needed to build and test the code?
> >
> > The same than for most other commons projects:
> >
> > ant
> > maven build
> > mvn install
> >
> > Choose what you prefer.
> >
> >> I could not find the information on the site.
> >
> > May be. However, if that is the case, then it was the same for at
> > least the previous two releases and it wasn't a blocking issue at the
> > time.
> >
> >> Also, build.xml seems to be out of date, as it refers to junit 3.8.1.
> >
> > I don't think this is a problem.
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release commons-fileupload 1.2.1 (rc4)
Posted by Oliver Heger <ol...@oliver-heger.de>.
+1
The build works for me in all variants as expected (on JDK 1.6). The
only minor nit I have is that the Copyright in the Javadocs still looks
a bit wired (at least on my browser): Instead of the Copyright character
I only get a "?".
Oliver
Jochen Wiedmann schrieb:
> Hi,
>
> I have prepared a release candidate 4 of commons-fileupload
> 1.2.1. The SVN tag is commons-fileupload-1.2.1rc4. A list of
> changes since rc3 and things that I haven't changes,
> can be found below.
>
> As usual, the proposed distributables can be found on
>
> http://people.apache.org/~jochen/commons-fileupload/dist
>
> The proposed site (unchanged since rc3) is on
>
> http://people.apache.org/~jochen/commons-fileupload/site
>
>
> Thanks,
>
> Jochen
>
>
> [ ] +1
> [ ] =0
> [ ] -1
>
>
> Changes since 1.2.1rc3:
>
> - Upgraded commons-parent to version 7. This means, in particular,
> that the maven-remote-resources-plugin is no longer used.
> - MD5 and SHA1 checksums now have the binary flag (*)
> - Fixed the copyright in the Javadoc bottom
> - Building with Ant and Java 1.3.1 works again.
>
> Other comments:
>
>> What does "(optional)" mean in the Dependencies section under Commons IO?
>
> It means optional. Commons-IO is required only, if you intend to use
> the DiskFileItem.
>
>
>> What commands are needed to build and test the code?
>
> The same than for most other commons projects:
>
> ant
> maven build
> mvn install
>
> Choose what you prefer.
>
>> I could not find the information on the site.
>
> May be. However, if that is the case, then it was the same for at
> least the previous two releases and it wasn't a blocking issue at the
> time.
>
>> Also, build.xml seems to be out of date, as it refers to junit 3.8.1.
>
> I don't think this is a problem.
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
RE: [VOTE] Release commons-fileupload 1.2.1 (rc4)
Posted by Gary Gregory <GG...@seagullsoftware.com>.
> From: Jochen Wiedmann [mailto:jochen.wiedmann@gmail.com]
> Sent: Sunday, January 20, 2008 11:40 AM
> To: Jakarta Commons Developers List
> Subject: Re: [VOTE] Release commons-fileupload 1.2.1 (rc4)
>
> On Jan 20, 2008 7:20 AM, Gary Gregory <GG...@seagullsoftware.com> wrote:
>
> > FYI, this RC builds and tests OK on the 9 SDKs I tested [1]
> >
> > Gary
> >
> > [1] http://garygregory.com/os/builds/index.html#commons-fileupload-1.2.1
>
> If so, what prevents you to vote with +1?
Good question. In this case, I've not taken the time to look over at least one of these builds at the level of detail that I am normally comfortable when casting a vote. I usually do a read over of the Javadocs, look at how reasonable the test coverage is (Clover), check to see if the bugs I care about have been fixed, look at compiler warnings, stuff like that.
Since I have a local build process set up to validate the components I do actively fiddle with (Codec, Lang and IO for example), I thought I'd run this component through the same build gauntlet for the benefit and/or curiosity of this project community.
Gary
>
>
> --
> Look, that's why there's rules, understand? So that you think before
> you break 'em.
>
> -- (Terry Pratchett, Thief of Time)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release commons-fileupload 1.2.1 (rc4)
Posted by Jochen Wiedmann <jo...@gmail.com>.
On Jan 20, 2008 7:20 AM, Gary Gregory <GG...@seagullsoftware.com> wrote:
> FYI, this RC builds and tests OK on the 9 SDKs I tested [1]
>
> Gary
>
> [1] http://garygregory.com/os/builds/index.html#commons-fileupload-1.2.1
If so, what prevents you to vote with +1?
--
Look, that's why there's rules, understand? So that you think before
you break 'em.
-- (Terry Pratchett, Thief of Time)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
RE: [VOTE] Release commons-fileupload 1.2.1 (rc4)
Posted by Gary Gregory <GG...@seagullsoftware.com>.
FYI, this RC builds and tests OK on the 9 SDKs I tested [1]
Gary
[1] http://garygregory.com/os/builds/index.html#commons-fileupload-1.2.1
Thank you,
Gary
> -----Original Message-----
> From: Jochen Wiedmann [mailto:jochen.wiedmann@gmail.com]
> Sent: Friday, January 18, 2008 1:46 PM
> To: Jakarta Commons Developers List
> Subject: [VOTE] Release commons-fileupload 1.2.1 (rc4)
>
> Hi,
>
> I have prepared a release candidate 4 of commons-fileupload
> 1.2.1. The SVN tag is commons-fileupload-1.2.1rc4. A list of
> changes since rc3 and things that I haven't changes,
> can be found below.
>
> As usual, the proposed distributables can be found on
>
> http://people.apache.org/~jochen/commons-fileupload/dist
>
> The proposed site (unchanged since rc3) is on
>
> http://people.apache.org/~jochen/commons-fileupload/site
>
>
> Thanks,
>
> Jochen
>
>
> [ ] +1
> [ ] =0
> [ ] -1
>
>
> Changes since 1.2.1rc3:
>
> - Upgraded commons-parent to version 7. This means, in particular,
> that the maven-remote-resources-plugin is no longer used.
> - MD5 and SHA1 checksums now have the binary flag (*)
> - Fixed the copyright in the Javadoc bottom
> - Building with Ant and Java 1.3.1 works again.
>
> Other comments:
>
> > What does "(optional)" mean in the Dependencies section under Commons IO?
>
> It means optional. Commons-IO is required only, if you intend to use
> the DiskFileItem.
>
>
> > What commands are needed to build and test the code?
>
> The same than for most other commons projects:
>
> ant
> maven build
> mvn install
>
> Choose what you prefer.
>
> > I could not find the information on the site.
>
> May be. However, if that is the case, then it was the same for at
> least the previous two releases and it wasn't a blocking issue at the
> time.
>
> > Also, build.xml seems to be out of date, as it refers to junit 3.8.1.
>
> I don't think this is a problem.
>
>
> --
> Look, that's why there's rules, understand? So that you think before
> you break 'em.
>
> -- (Terry Pratchett, Thief of Time)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release commons-fileupload 1.2.1 (rc4)
Posted by sebb <se...@gmail.com>.
On 18/01/2008, Jochen Wiedmann <jo...@gmail.com> wrote:
> Hi,
>
> I have prepared a release candidate 4 of commons-fileupload
> 1.2.1. The SVN tag is commons-fileupload-1.2.1rc4. A list of
> changes since rc3 and things that I haven't changes,
> can be found below.
>
> As usual, the proposed distributables can be found on
>
> http://people.apache.org/~jochen/commons-fileupload/dist
>
Contents of archives look OK, and digests are OK.
> The proposed site (unchanged since rc3) is on
>
> http://people.apache.org/~jochen/commons-fileupload/site
>
>
> Thanks,
>
> Jochen
>
>
> [ ] +1
> [ ] =0
> [ ] -1
>
>
> Changes since 1.2.1rc3:
>
> - Upgraded commons-parent to version 7. This means, in particular,
> that the maven-remote-resources-plugin is no longer used.
> - MD5 and SHA1 checksums now have the binary flag (*)
> - Fixed the copyright in the Javadoc bottom
> - Building with Ant and Java 1.3.1 works again.
>
> Other comments:
>
> > What does "(optional)" mean in the Dependencies section under Commons IO?
>
> It means optional. Commons-IO is required only, if you intend to use
> the DiskFileItem.
>
For the next release, perhaps consider linking to where this is described?
>
> > What commands are needed to build and test the code?
>
> The same than for most other commons projects:
>
> ant
ant creates the jar, but the LICENSE is missing
but otherwise it seems to work compile and test OK.
> maven build
Goal does not exist:
commons-fileupload-1.2.1-src>maven build
__ __
| \/ |__ _Apache__ ___
| |\/| / _` \ V / -_) ' \ ~ intelligent projects ~
|_| |_\__,_|\_/\___|_||_| v. 1.1
DEPRECATED: the default goal should be specified in the <build>
section of project.xml instead of maven.xml
-------------------------------------------------------------------------------
>> Goal 'build' does not exist in this project.
"dist:build" does exist, but fails with:
-------------------------------------------------------
>> Unable to obtain goal [dist:prepare-bin-filesystem]
>> Unions are only allowed over node-sets
-------------------------------------------------------
BUILD FAILED
> mvn install
Seems to work OK.
> Choose what you prefer.
>
> > I could not find the information on the site.
>
> May be. However, if that is the case, then it was the same for at
> least the previous two releases and it wasn't a blocking issue at the
> time.
Agreed, it's not blocking for the release, but it is blocking for
(some) people wanting to test the release...
I think the build instructions should be included in a file (e.g.
README) in the source archives; it would not harm to include the
information on the site as well, e.g. as done by
http://commons.apache.org/io/building.html
http://commons.apache.org/lang/building.html
> > Also, build.xml seems to be out of date, as it refers to junit 3.8.1.
>
> I don't think this is a problem.
>
It's not a blocker, but should be upgraded for the next release along
with project.xml which also refers to 3.8.1, whereas pom.xml is 3.8.2
>
> --
> Look, that's why there's rules, understand? So that you think before
> you break 'em.
>
> -- (Terry Pratchett, Thief of Time)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[RESULT] Release commons-fileupload 1.2.1 (rc4)
Posted by Jochen Wiedmann <jo...@gmail.com>.
Passed with
+1: 4 (Rahul, Niall, Oliver, Myself)
I am not counting the replies by sebb and Gary, because I didn't have
the impression that they have been votes.
I'll do the release today.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release commons-fileupload 1.2.1 (rc4)
Posted by Jochen Wiedmann <jo...@gmail.com>.
On Jan 31, 2008 4:11 PM, Niall Pemberton <ni...@gmail.com> wrote:
> *ping*
Sorry, Niall, I've been in vacation for one week and was otherwise
busy. I'll do the release today.
--
Look, that's why there's rules, understand? So that you think before
you break 'em.
-- (Terry Pratchett, Thief of Time)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release commons-fileupload 1.2.1 (rc4)
Posted by Niall Pemberton <ni...@gmail.com>.
*ping*
On Jan 18, 2008 9:46 PM, Jochen Wiedmann <jo...@gmail.com> wrote:
> Hi,
>
> I have prepared a release candidate 4 of commons-fileupload
> 1.2.1. The SVN tag is commons-fileupload-1.2.1rc4. A list of
> changes since rc3 and things that I haven't changes,
> can be found below.
>
> As usual, the proposed distributables can be found on
>
> http://people.apache.org/~jochen/commons-fileupload/dist
>
> The proposed site (unchanged since rc3) is on
>
> http://people.apache.org/~jochen/commons-fileupload/site
>
>
> Thanks,
>
> Jochen
>
>
> [ ] +1
> [ ] =0
> [ ] -1
>
>
> Changes since 1.2.1rc3:
>
> - Upgraded commons-parent to version 7. This means, in particular,
> that the maven-remote-resources-plugin is no longer used.
> - MD5 and SHA1 checksums now have the binary flag (*)
> - Fixed the copyright in the Javadoc bottom
> - Building with Ant and Java 1.3.1 works again.
>
> Other comments:
>
> > What does "(optional)" mean in the Dependencies section under Commons IO?
>
> It means optional. Commons-IO is required only, if you intend to use
> the DiskFileItem.
>
>
> > What commands are needed to build and test the code?
>
> The same than for most other commons projects:
>
> ant
> maven build
> mvn install
>
> Choose what you prefer.
>
> > I could not find the information on the site.
>
> May be. However, if that is the case, then it was the same for at
> least the previous two releases and it wasn't a blocking issue at the
> time.
>
> > Also, build.xml seems to be out of date, as it refers to junit 3.8.1.
>
> I don't think this is a problem.
>
>
> --
> Look, that's why there's rules, understand? So that you think before
> you break 'em.
>
> -- (Terry Pratchett, Thief of Time)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release commons-fileupload 1.2.1 (rc4)
Posted by Rahul Akolkar <ra...@gmail.com>.
On 1/18/08, Jochen Wiedmann <jo...@gmail.com> wrote:
<snip/>
>
> [X] +1
> [ ] =0
> [ ] -1
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org