You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/05/13 01:58:28 UTC
[GitHub] [lucene-solr] dnhatn opened a new pull request #2494: LUCENE-9935: Enable bulk merge for stored fields with index sort
dnhatn opened a new pull request #2494:
URL: https://github.com/apache/lucene-solr/pull/2494
This commit enables bulk-merges (i.e., raw chunk copying) for stored
fields when index sort is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dnhatn merged pull request #2494: LUCENE-9935: Enable bulk merge for stored fields with index sort
Posted by GitBox <gi...@apache.org>.
dnhatn merged pull request #2494:
URL: https://github.com/apache/lucene-solr/pull/2494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dnhatn merged pull request #2494: LUCENE-9935: Enable bulk merge for stored fields with index sort
Posted by GitBox <gi...@apache.org>.
dnhatn merged pull request #2494:
URL: https://github.com/apache/lucene-solr/pull/2494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dnhatn commented on pull request #2494: LUCENE-9935: Enable bulk merge for stored fields with index sort
Posted by GitBox <gi...@apache.org>.
dnhatn commented on pull request #2494:
URL: https://github.com/apache/lucene-solr/pull/2494#issuecomment-840242660
@rmuir Sure, I will defer the backport. Thank you for your suggestion :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] rmuir commented on pull request #2494: LUCENE-9935: Enable bulk merge for stored fields with index sort
Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #2494:
URL: https://github.com/apache/lucene-solr/pull/2494#issuecomment-840245380
we don't have to wait forever on it btw. e.g. if we decide we want it in 8.9, i'd just propose we adjust any release schedule to fit. I would ping @mayya-sharipova and maybe the dev list as well if that's what you want to do. it means giving a day or 2 for CI baking here and there to be safe. Maybe this extra time should be given to LUCENE-9827 as well (it must bump an internal format as well, if it wants to store new chunk counts).
for example, I tested this change myself against main, but i only ran the test a couple times. didn't test the change with Nightly because that is what CI is for. So at least one nightly run and a couple other CI runs helps a lot to find the bugs now, instead of the users. Look at followup commits to LUCENE-9827 to get an idea of what can go wrong :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] rmuir commented on pull request #2494: LUCENE-9935: Enable bulk merge for stored fields with index sort
Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #2494:
URL: https://github.com/apache/lucene-solr/pull/2494#issuecomment-840241723
I'd prefer if we didn't backport this one immediately to stable branch. I think at least bake it a bit in `main` branch with some CI and nightly tests?
@jpountz mentioned that he planned to backport https://issues.apache.org/jira/browse/LUCENE-9827 which I think is safe... it baked a bit, and there were some followup commits fixing bugs found by CI/nightly :)
To me it makes sense to backport that one first and then consider this one (it is hard for me to reason about these bulk merge changes out of order) Really it is decision of the release manager, I am just making suggestions. I think we should take steps to reduce risks for this part of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org