You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:29:49 UTC
[GitHub] [airflow] turbaszek opened a new pull request #12040: Remove setstate and getstate from BaseOperator
turbaszek opened a new pull request #12040:
URL: https://github.com/apache/airflow/pull/12040
It seems that those methods implement no useful logic as
the _log attribute is never used anywhere.
This is potentially breaking change because user may use `op._log` instead of `op.log`.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #12040: Remove setstate and getstate from BaseOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #12040:
URL: https://github.com/apache/airflow/pull/12040#issuecomment-720518376
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12040: Remove setstate and getstate from BaseOperator
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12040:
URL: https://github.com/apache/airflow/pull/12040#issuecomment-720749924
These methods are used by pickle - even though we don't use it in airflow right now I think we should keep these.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek closed pull request #12040: Remove setstate and getstate from BaseOperator
Posted by GitBox <gi...@apache.org>.
turbaszek closed pull request #12040:
URL: https://github.com/apache/airflow/pull/12040
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #12040: Remove setstate and getstate from BaseOperator
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #12040:
URL: https://github.com/apache/airflow/pull/12040#issuecomment-720480779
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek edited a comment on pull request #12040: Remove setstate and getstate from BaseOperator
Posted by GitBox <gi...@apache.org>.
turbaszek edited a comment on pull request #12040:
URL: https://github.com/apache/airflow/pull/12040#issuecomment-720618224
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org