You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Roger Meier <ro...@bufferoverflow.ch> on 2014/02/02 22:15:16 UTC

RE: **** SPAM [ 7.8 ] **** Re: Re: [jira] [Commented] (THRIFT-2190) Add the JavaScript thrift.js lib to the Bower registry

Rename might break existing references...

However, I'm fine with a rename of existing tag.

Please do sign the tags as well.

Thanks
Roger


-----Original Message-----
From: Jake Farrell [mailto:jfarrell@apache.org] 
Sent: Sonntag, 2. Februar 2014 21:38
To: dev@thrift.apache.org
Subject: **** SPAM [ 7.8 ] **** Re: Re: [jira] [Commented] (THRIFT-2190) Add
the JavaScript thrift.js lib to the Bower registry

These new tags are redundant and I would prefer that we just rename the tags
that existed rather than duplicating with the comment semver.

I'll update the process and clean up the existing tags and we can include
the js package in the release process for submitting to bower.

-Jake




On Sun, Feb 2, 2014 at 3:25 PM, Randy Abernethy
<ra...@gmail.com>wrote:

> Hey Henrique and Roger,
>
> Super great to move the Bower initiative forward. Regarding what we 
> should publish over Bower, I think it should be the necessary bits for 
> front end development.
>    -  lib/js/dist/README.md
>    -  lib/js/dist/thrift.js
>    -  lib/js/dist/thrift.min.js
>    -  lib/js/dist/bower.json
>
> The README.md needs to be updated and emitted in the grunt build along 
> with the bower file but otherwise we're there.
>
> Here's a session using bower to add AngularJS to a front end web project.
> AngularJS
> is a pretty well respected MVC framework from Google and the files 
> they include in their Bower deployment are a good approximation of 
> what the community might be expecting.
> Globally replace the word "angular" with the word "thrift" and I think 
> you have a good model.
>
> -Randy
>
> <code>
> Randy@VAVAU /d/dev/test/bt
> $ bower install angular
> bower angular#*                 cached git://
> github.com/angular/bower-angular.git#1.0.8
> bower angular#*               validate 1.0.8 against git://
> github.com/angular/bower-angular.git#*
> bower angular#*                    new version for git://
> github.com/angular/bower-angular.git#*
> bower angular#*                resolve git://
> github.com/angular/bower-angular.git#*
> bower angular#*               download
> https://github.com/angular/bower-angular/archive/v1.2.10.tar.gz
> bower angular#*                extract archive.tar.gz
> bower angular#*               resolved git://
> github.com/angular/bower-angular.git#1.2.10
> bower angular#~1.2.10          install angular#1.2.10
>
> angular#1.2.10 bower_components\angular
>
> Randy@VAVAU /d/dev/test/bt
> $ ls -l bower_components/angular/
> total 557
> -rw-r--r--    1 Randy    Administ     1615 Feb  2 12:08 README.md
> -rw-r--r--    1 Randy    Administ      241 Feb  2 12:08 angular-csp.css
> -rw-r--r--    1 Randy    Administ   727582 Feb  2 12:08 angular.js
> -rw-r--r--    1 Randy    Administ   100085 Feb  2 12:08 angular.min.js
> -rw-r--r--    1 Randy    Administ    36933 Feb  2 12:08
angular.min.js.gzip
> -rw-r--r--    1 Randy    Administ   269869 Feb  2 12:08 angular.min.js.map
> -rw-r--r--    1 Randy    Administ       98 Feb  2 12:08 bower.json
>
> </code>
>
>
>
>
>
>
>
> On Sun, Feb 2, 2014 at 11:10 AM, Henrique Mendonça 
> <henrique@apache.org
> >wrote:
>
> > Awesome Roger, thanks heaps!
> >
> > Randy, do you have anything to add/amend on my bower file? I'm not 
> > sure
> if
> > we should ignore all the other libraries, compiler, etc, should we?
> > Although it's not JS at all, perhaps the user might want to build 
> > the compiler/tests... what do you guys think?
> > Anyway, if you have a bower file you can attach it to the ticket 
> > here I'd be happy to commit and register it. "thrift" seems to be 
> > still available
> :)
> >
> > Cheers,
> > Henrique
> >
> >
> > On 2 February 2014 18:16, Roger Meier <ro...@bufferoverflow.ch> wrote:
> >
> > > There is now real reason for "thrift-" prefix within tag name.
> > > Bryan did this and Jake as well, however we all already agree on 
> > > the
> > semver
> > > concept.
> > > See http://thrift.apache.org/docs/committers/HowToVersion
> > >
> > > So I added these signed semver tags:
> > > 0.2.0
> > > 0.3.0
> > > 0.4.0
> > > 0.6.0
> > > 0.7.0
> > > 0.8.0
> > > 0.9.0
> > > 0.9.1
> > >
> > >
> > > We should add the bower.json file to the root folder
> > >
> > > -roger
> > >
> > >
> > > -----Original Message-----
> > > From: hmendonca@gmail.com [mailto:hmendonca@gmail.com] On Behalf 
> > > Of Henrique Mendonça
> > > Sent: Sonntag, 2. Februar 2014 13:43
> > > To: dev@thrift.apache.org
> > > Subject: **** SPAM [ 7.901 ] **** Re: [jira] [Commented] 
> > > (THRIFT-2190)
> > Add
> > > the JavaScript thrift.js lib to the Bower registry
> > >
> > > Hi Randy,
> > >
> > > I think you can test it with your own fork like:
> > > https://github.com/henrique/thrift/blob/master/bower.json
> > > bower install https://github.com/henrique/thrift.git
> > >
> > > I don't really use bower so I am not sure if this reference to
> > /lib/js/src
> > > works. However, if it does we would only need to have standard 
> > > semver
> > tags
> > > the official git repo. Our current tags from 0.6 always start with 
> > > "thrift-"
> > > so bower only recognizes 0.5.0 on the current repo. We'd need to 
> > > add
> new
> > > tags like in http://semver.org/ : "M.M.P" or "vM.M.P"
> > >
> > > @Jake&Roger: why did we start appending thrift- to our tags after 0.5?
> > >
> > > Cheers,
> > > Henrique
> > >
> > >
> > > On 1 February 2014 22:28, Randy Abernethy (JIRA) <ji...@apache.org>
> > wrote:
> > >
> > > >
> > > >     [
> > > >
> https://issues.apache.org/jira/browse/THRIFT-2190?page=com.atlassian.j
> > > >
> ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138
> > > > 88743#comment-13888743]
> > > >
> > > > Randy Abernethy commented on THRIFT-2190:
> > > > -----------------------------------------
> > > >
> > > > Someone with the appropriate authority needs to run the
registration.
> > > > Also the library posted should be the output of the JS grunt 
> > > > build
> (in
> > > js/dist).
> > > > This way as the js/src grows and separate files manifest the 
> > > > js/dist will continue to present a single concatenated minified 
> > > > gzipped thrift.js archive for distribution. This will require 
> > > > the js/dist to appear at some git end point.
> > > >
> > > > Per Bower:
> > > > To register a new package:
> > > >      There must be a valid manifest JSON in the current working
> > > directory.
> > > >      Your package should use semver Git tags.
> > > >      Your package must be available at a Git endpoint (e.g., 
> > > > GitHub); remember to push your Git tags!
> > > > Then use the following command:
> > > >      bower register <my-package-name> <git-endpoint> The Bower 
> > > > registry does not have authentication or user management at this
> point
> > > > in time. It's on a first come, first served basis. Think of it 
> > > > like a URL shortener. Now anyone can run bower install 
> > > > <my-package-name>,
> and
> > > > get your library installed.
> > > >
> > > > There is no direct way to unregister a package yet. For now, you 
> > > > can request a package be unregistered.
> > > >
> > > > > Add the JavaScript thrift.js lib to the Bower registry
> > > > > ------------------------------------------------------
> > > > >
> > > > >                 Key: THRIFT-2190
> > > > >                 URL:
> > https://issues.apache.org/jira/browse/THRIFT-2190
> > > > >             Project: Thrift
> > > > >          Issue Type: Wish
> > > > >          Components: JavaScript - Library
> > > > >    Affects Versions: 1.0
> > > > >            Reporter: Randy Abernethy
> > > > >            Assignee: Randy Abernethy
> > > > >            Priority: Minor
> > > > >              Labels: Bower,, Grunt,, package.json
> > > > >             Fix For: 0.9.2
> > > > >
> > > > >         Attachments:
> > > > 0001-Setup-grunt-and-package.json-project-for-browser-thr.patch
> > > > >
> > > > >
> > > > > Grunt/Bower/Yeoman appear to have the wind at their back. 
> > > > > Would be great
> > > > for front end JavaScript developers to be able to bower install
> thrift.
> > > > > http://bower.io/
> > > > > This patch adds a grunt project, jsdoc, jshint, concat,
> minification
> > > > > and
> > > > qunit test runner.
> > > >
> > > >
> > > >
> > > > --
> > > > This message was sent by Atlassian JIRA
> > > > (v6.1.5#6160)
> > > >
> > >
> >
>