[GitHub] [hive] jcamachor commented on a change in pull request #755: HIVE-22107 Correlated subquery producing wrong schema

[GitBox <gi...@apache.org>]

jcamachor commented on a change in pull request #755: HIVE-22107 Correlated subquery producing wrong schema
URL: https://github.com/apache/hive/pull/755#discussion_r320470567
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSubQueryRemoveRule.java
 ##########
 @@ -199,7 +199,7 @@ private RexNode rewriteScalar(RelMetadataQuery mq, RexSubQuery e, Set<Correlatio
 
       // id is appended since there could be multiple scalar subqueries and FILTER
       // is created using field name
-      String indicator = "alwaysTrue" + e.rel.getId();
+      String indicator = "trueLiteral";
 
 Review comment:
   Please move this to a private static constant variable at the class level, so you do not have to declare multiple times same String value.
   In addition, can this name clash with any other column name in the operator?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org