You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/05/25 14:02:14 UTC

[GitHub] [cloudstack] slavkap commented on a change in pull request #4631: fix: create template with Marvin

slavkap commented on a change in pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#discussion_r638817965



##########
File path: tools/marvin/marvin/lib/base.py
##########
@@ -1521,12 +1513,12 @@ def _set_command(cls, apiclient, cmd, services, random_name=True):
             raise Exception(
                 "Unable to find Ostype is required for creating template")
 
-        cmd.snapshotid = snapshot.id
+        if volume:
+            cmd.volumeid = volume.id
+
+        if snapshot:
+            cmd.snapshotid = snapshot.id
 
-        if account:

Review comment:
       @rhtyd, yes, there is no need to provide account/domain, according to the  - [API docs ](https://cloudstack.apache.org/api/apidocs-4.15/apis/createTemplate.html)
   also, I've checked the code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org