You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2022/07/29 21:24:55 UTC
[GitHub] [qpid-proton] astitcher opened a new pull request, #377: Update Travis CI to stop using Xenial and use Focal instead
astitcher opened a new pull request, #377:
URL: https://github.com/apache/qpid-proton/pull/377
Xenial is over 5 years old now - I don't think we need to make sure we build on it any longer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on a diff in pull request #377: Update Travis CI to stop using Xenial and use Focal instead
Posted by GitBox <gi...@apache.org>.
astitcher commented on code in PR #377:
URL: https://github.com/apache/qpid-proton/pull/377#discussion_r934611460
##########
.travis.yml:
##########
@@ -17,81 +17,57 @@
# under the License
#
+os: linux
+dist: focal
+language: cpp
+env:
+- PYTHON=python3
jobs:
include:
- - os: linux
- dist: xenial
- language: cpp
- compiler: gcc
- env:
- - OPENSSL_ia32cap='0x00000000'
- - os: linux
- dist: xenial
- language: cpp
- compiler: clang
- env:
- - OPENSSL_ia32cap='0x00000000'
+ - compiler: gcc
+ - compiler: clang
# c-threaderciser test hangs on older clang
Review Comment:
Thanks for that syntax checking! It seems to have launched a travis job now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on pull request #377: Update Travis CI to stop using Xenial and use Focal instead
Posted by GitBox <gi...@apache.org>.
astitcher commented on PR #377:
URL: https://github.com/apache/qpid-proton/pull/377#issuecomment-1201435832
@jiridanek so it still fails because it seems that the specific matrix entries override the entire global env instead of adding to it so python3 can't be common using an env var if different jobs have env vars.
istm that there should be a way to just add env vars for matrix jobs - any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] asfgit merged pull request #377: Update Travis CI to stop using Xenial and use Focal instead
Posted by GitBox <gi...@apache.org>.
asfgit merged PR #377:
URL: https://github.com/apache/qpid-proton/pull/377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on pull request #377: Update Travis CI to stop using Xenial and use Focal instead
Posted by GitBox <gi...@apache.org>.
jiridanek commented on PR #377:
URL: https://github.com/apache/qpid-proton/pull/377#issuecomment-1201307137
> @jiridanek Did you have anything else you wanted to change in the travis job?
Nothing urgent. Upgrade clang version in that job where it explicitly installs clang from apt repo, maybe. When that was added, it installed the latest clang, but now there were few clang releases in between. But that is something to be done in the future, not in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on pull request #377: Update Travis CI to stop using Xenial and use Focal instead
Posted by GitBox <gi...@apache.org>.
jiridanek commented on PR #377:
URL: https://github.com/apache/qpid-proton/pull/377#issuecomment-1201468248
> @jiridanek so it still fails because it seems that the specific matrix entries override the entire global env instead of adding to it so python3 can't be common using an env var if different jobs have env vars.
>
> istm that there should be a way to just add env vars for matrix jobs - any ideas?
If there is shared `script` block or something, maybe you can do `export PYTHON=python3`? Otherwise I think you have to repeat the variable in every row of the matrix, such as the PROTON_VERSION=main in https://github.com/jiridanek/skupper-router/blob/main/.travis.yml#L31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on pull request #377: Update Travis CI to stop using Xenial and use Focal instead
Posted by GitBox <gi...@apache.org>.
astitcher commented on PR #377:
URL: https://github.com/apache/qpid-proton/pull/377#issuecomment-1201301142
@jiridanek Did you have anything else you wanted to change in the travis job?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] codecov-commenter commented on pull request #377: Update Travis CI to stop using Xenial and use Focal instead
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #377:
URL: https://github.com/apache/qpid-proton/pull/377#issuecomment-1201366108
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#377](https://codecov.io/gh/apache/qpid-proton/pull/377?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54f384f) into [main](https://codecov.io/gh/apache/qpid-proton/commit/9c639d1f59857061da4d9d40630132b7ce92658f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9c639d1) will **decrease** coverage by `18.74%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #377 +/- ##
===========================================
- Coverage 88.34% 69.60% -18.75%
===========================================
Files 47 368 +321
Lines 2394 71553 +69159
===========================================
+ Hits 2115 49802 +47687
- Misses 279 21751 +21472
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [ruby/lib/util/error\_handler.rb](https://codecov.io/gh/apache/qpid-proton/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvdXRpbC9lcnJvcl9oYW5kbGVyLnJi) | `59.37% <0.00%> (-28.13%)` | :arrow_down: |
| [ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29kZWMvZGF0YS5yYg==) | `76.95% <0.00%> (-19.14%)` | :arrow_down: |
| [cpp/src/null.cpp](https://codecov.io/gh/apache/qpid-proton/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9udWxsLmNwcA==) | `0.00% <0.00%> (ø)` | |
| [c/src/platform/platform.c](https://codecov.io/gh/apache/qpid-proton/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvcGxhdGZvcm0vcGxhdGZvcm0uYw==) | `23.80% <0.00%> (ø)` | |
| [c/tests/engine\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy9lbmdpbmVfdGVzdC5jcHA=) | `100.00% <0.00%> (ø)` | |
| [c/src/core/engine.c](https://codecov.io/gh/apache/qpid-proton/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9lbmdpbmUuYw==) | `94.00% <0.00%> (ø)` | |
| [cpp/include/proton/receiver\_options.hpp](https://codecov.io/gh/apache/qpid-proton/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3JlY2VpdmVyX29wdGlvbnMuaHBw) | `100.00% <0.00%> (ø)` | |
| [c/tools/include/pncompat/misc\_funcs.inc](https://codecov.io/gh/apache/qpid-proton/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90b29scy9pbmNsdWRlL3BuY29tcGF0L21pc2NfZnVuY3MuaW5j) | `100.00% <0.00%> (ø)` | |
| [cpp/include/proton/session\_options.hpp](https://codecov.io/gh/apache/qpid-proton/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3Nlc3Npb25fb3B0aW9ucy5ocHA=) | `0.00% <0.00%> (ø)` | |
| [cpp/src/connection\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9jb25uZWN0aW9uX29wdGlvbnMuY3Bw) | `91.11% <0.00%> (ø)` | |
| ... and [313 more](https://codecov.io/gh/apache/qpid-proton/pull/377/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on pull request #377: Update Travis CI to stop using Xenial and use Focal instead
Posted by GitBox <gi...@apache.org>.
astitcher commented on PR #377:
URL: https://github.com/apache/qpid-proton/pull/377#issuecomment-1201526630
Figured it out from the docs: you can add a global stanza to the env block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on pull request #377: Update Travis CI to stop using Xenial and use Focal instead
Posted by GitBox <gi...@apache.org>.
astitcher commented on PR #377:
URL: https://github.com/apache/qpid-proton/pull/377#issuecomment-1199974778
I was hoping to get Travis to build this PR but having force pushed a change it looks like it's not doing another build! :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on a diff in pull request #377: Update Travis CI to stop using Xenial and use Focal instead
Posted by GitBox <gi...@apache.org>.
jiridanek commented on code in PR #377:
URL: https://github.com/apache/qpid-proton/pull/377#discussion_r933811708
##########
.travis.yml:
##########
@@ -17,81 +17,57 @@
# under the License
#
+os: linux
+dist: focal
+language: cpp
+env:
+- PYTHON=python3
jobs:
include:
- - os: linux
- dist: xenial
- language: cpp
- compiler: gcc
- env:
- - OPENSSL_ia32cap='0x00000000'
- - os: linux
- dist: xenial
- language: cpp
- compiler: clang
- env:
- - OPENSSL_ia32cap='0x00000000'
+ - compiler: gcc
+ - compiler: clang
# c-threaderciser test hangs on older clang
Review Comment:
> I was hoping to get Travis to build this PR but having force pushed a change it looks like it's not doing another build! :-(
Could be due to syntax error, you are missing `env:` here!
Also, I have my doubts about few other things in this file. There should be a travis syntax checker somewhere! https://github.com/travis-ci/travis.rb#lint maybe, but I hoped for something online, where I can paste file and it will give me report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org