You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/13 00:12:58 UTC
[GitHub] [pulsar] rdhabalia opened a new pull request, #15143: [pulsar-client] Add message chunking configuration for reader
rdhabalia opened a new pull request, #15143:
URL: https://github.com/apache/pulsar/pull/15143
### Motivation
Pulsar readers can also read large message and can utilize message chunking feature. however, reader doesn't have chunking config to tune message-chunking feature based on application usecase.
### Modification
Add message-chunking configuration in reader-config to tune reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15143: [pulsar-client] Add message chunking configuration for reader
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15143:
URL: https://github.com/apache/pulsar/pull/15143#issuecomment-1097414878
@rdhabalia:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #15143: [pulsar-client] Add message chunking configuration for reader
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on PR #15143:
URL: https://github.com/apache/pulsar/pull/15143#issuecomment-1099330298
@RobertIndie PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia merged pull request #15143: [pulsar-client] Add message chunking configuration for reader
Posted by GitBox <gi...@apache.org>.
rdhabalia merged PR #15143:
URL: https://github.com/apache/pulsar/pull/15143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on a diff in pull request #15143: [pulsar-client] Add message chunking configuration for reader
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on code in PR #15143:
URL: https://github.com/apache/pulsar/pull/15143#discussion_r850585292
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ReaderConfigurationData.java:
##########
@@ -67,6 +68,13 @@
private transient List<ReaderInterceptor<T>> readerInterceptorList;
+ // max pending chunked message to avoid sending incomplete message into the queue and memory
+ private int maxPendingChunkedMessage = 10;
Review Comment:
it's configured in `ReaderImpl` and `MultiTopicsReaderImpl`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #15143: [pulsar-client] Add message chunking configuration for reader
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on PR #15143:
URL: https://github.com/apache/pulsar/pull/15143#issuecomment-1098453470
> I think we also need a test to verify these configurations are able to be set to the internal consumer correctly.
Sure, I have added that test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #15143: [pulsar-client] Add message chunking configuration for reader
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #15143:
URL: https://github.com/apache/pulsar/pull/15143#issuecomment-1098627416
@momo-jun a soft reminder: here is a PR w/ doc-required label, could u pls follow up? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on a diff in pull request #15143: [pulsar-client] Add message chunking configuration for reader
Posted by GitBox <gi...@apache.org>.
RobertIndie commented on code in PR #15143:
URL: https://github.com/apache/pulsar/pull/15143#discussion_r849302561
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ReaderConfigurationData.java:
##########
@@ -67,6 +68,13 @@
private transient List<ReaderInterceptor<T>> readerInterceptorList;
+ // max pending chunked message to avoid sending incomplete message into the queue and memory
+ private int maxPendingChunkedMessage = 10;
Review Comment:
Where do we pass these configurations to the internal consumer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #15143: [pulsar-client] Add message chunking configuration for reader
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on PR #15143:
URL: https://github.com/apache/pulsar/pull/15143#issuecomment-1098492151
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org