You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/07/13 02:41:33 UTC
[GitHub] [pulsar] codecov-commenter commented on pull request #20791: [improve][io] Add notifyError method on PushSource.
codecov-commenter commented on PR #20791:
URL: https://github.com/apache/pulsar/pull/20791#issuecomment-1633457429
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20791?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#20791](https://app.codecov.io/gh/apache/pulsar/pull/20791?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a8af71f) into [master](https://app.codecov.io/gh/apache/pulsar/commit/e96b3398912163eb6e0528c10aed3507c95952fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e96b339) will **increase** coverage by `39.65%`.
> The diff coverage is `80.64%`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20791?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #20791 +/- ##
=============================================
+ Coverage 33.44% 73.09% +39.65%
- Complexity 12097 32115 +20018
=============================================
Files 1612 1867 +255
Lines 126568 139040 +12472
Branches 13824 15294 +1470
=============================================
+ Hits 42328 101629 +59301
+ Misses 78686 29346 -49340
- Partials 5554 8065 +2511
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.07% <0.00%> (-0.02%)` | :arrow_down: |
| systests | `25.05% <3.22%> (?)` | |
| unittests | `72.37% <80.64%> (+40.43%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pulsar/pull/20791?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rg/apache/pulsar/broker/service/BrokerService.java](https://app.codecov.io/gh/apache/pulsar/pull/20791?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0Jyb2tlclNlcnZpY2UuamF2YQ==) | `81.82% <ø> (+26.02%)` | :arrow_up: |
| [.../org/apache/pulsar/io/core/AbstractPushSource.java](https://app.codecov.io/gh/apache/pulsar/pull/20791?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWlvL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9pby9jb3JlL0Fic3RyYWN0UHVzaFNvdXJjZS5qYXZh) | `76.92% <76.92%> (ø)` | |
| [...rg/apache/pulsar/client/impl/TopicListWatcher.java](https://app.codecov.io/gh/apache/pulsar/pull/20791?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1RvcGljTGlzdFdhdGNoZXIuamF2YQ==) | `66.66% <100.00%> (+43.47%)` | :arrow_up: |
| [...ava/org/apache/pulsar/io/core/BatchPushSource.java](https://app.codecov.io/gh/apache/pulsar/pull/20791?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWlvL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9pby9jb3JlL0JhdGNoUHVzaFNvdXJjZS5qYXZh) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |
| [...ain/java/org/apache/pulsar/io/core/PushSource.java](https://app.codecov.io/gh/apache/pulsar/pull/20791?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWlvL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9pby9jb3JlL1B1c2hTb3VyY2UuamF2YQ==) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |
... and [1515 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20791/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org