You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/12 06:13:12 UTC
[GitHub] [cloudstack] jbampton opened a new pull request #4687: refactor: remove trailing whitespace from Python files
jbampton opened a new pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687
### Description
Need to have standardized Python code.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#discussion_r810868088
##########
File path: .github/workflows/linter.yml
##########
@@ -0,0 +1,14 @@
+name: Lint Code Base
Review comment:
license missing
##########
File path: .github/linters/.flake8
##########
@@ -0,0 +1,2 @@
+[flake8]
Review comment:
the build will fail at files without license header unless explicit exceptions are made. You'll need to add a license here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4687: [WIP] - refactor: remove trailing whitespace from Python files
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-918863606
Ping @jbampton are you working on this, can you resolve conflicts? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4687: [WIP] - refactor: remove trailing whitespace from Python files
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1044845166
Hi @jbampton can you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] jbampton commented on pull request #4687: [WIP] - refactor: remove trailing whitespace from Python files
Posted by GitBox <gi...@apache.org>.
jbampton commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1045882791
@DaanHoogland I have included both `spaces` and `tab` in this update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1072395631
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4687: refactor: remove trailing whitespace from Python files
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-778067300
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] jbampton commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
jbampton commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1081400077
Thanks everyone 💯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1076401862
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1076441587
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1079565169
<b>Trillian test result (tid-3730)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28925 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4687-t3730-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1072395631
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4687: [WIP] - refactor: remove trailing whitespace from Python files
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-778594815
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1072396666
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1072859555
<b>Trillian test result (tid-3665)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31260 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4687-t3665-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] jbampton commented on pull request #4687: [WIP] - refactor: remove trailing whitespace from Python files
Posted by GitBox <gi...@apache.org>.
jbampton commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-778361533
Hey @DaanHoogland I only looked at `trailing whitespace` so far.
I was going to add a `GitHub Action` to run `flake8` to test for `W291` for trailing whitespace.
By adding this check it will mean it will stop regressions.
Yes I am interested in cleaning up `tab` problems in future and / or other Python linting problems.
https://flake8.pycqa.org/en/latest/
https://www.flake8rules.com/rules/W291.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1079258404
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] jbampton commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
jbampton commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1076353580
Hey @weizhouapache GitHub Actions don't run the first time they are added to a repo with a pull request.
So this PR will need to be merged and then new PRs will run this GitHub Action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1080946123
Many thanks @jbampton PR merged, I can see the Github Action working for new PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1070356621
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1070335670
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4687: refactor: remove trailing whitespace from Python files
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-778068026
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] jbampton commented on pull request #4687: [WIP] - refactor: remove trailing whitespace from Python files
Posted by GitBox <gi...@apache.org>.
jbampton commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1045873902
@rohityadavcloud and @nvazquez I have removed the conflicts now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1070335435
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1072396666
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4687: [WIP] - refactor: remove trailing whitespace from Python files
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-924034455
Moving it to the next milestone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4687: refactor: remove trailing whitespace from Python files
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-778086824
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1076402310
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1074214790
Hi @DaanHoogland @weizhouapache @Pearl1594 could you please review? Smoke tests look good, no major changes besides removing spaces, I think it should be good to merge after approvals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1079258683
@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4687: refactor: remove trailing whitespace from Python files
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-778065318
thanks @jbampton , I will try to merge this asap, Have you just removed trailing spaces or also looked at tab (especially component tests have that problem)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4687: Add Python flake8 linting for W291 trailing whitespace with Super-Linter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4687:
URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-1079565359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org