You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by px...@apache.org on 2017/07/30 18:39:11 UTC
hive git commit: HIVE-17185:
TestHiveMetaStoreStatsMerge.testStatsMerge is failing (Pengcheng Xiong)
Repository: hive
Updated Branches:
refs/heads/master f53d07b86 -> 483ac74d8
HIVE-17185: TestHiveMetaStoreStatsMerge.testStatsMerge is failing (Pengcheng Xiong)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/483ac74d
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/483ac74d
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/483ac74d
Branch: refs/heads/master
Commit: 483ac74d821d15800ba6cd35486db7c37bf6a40d
Parents: f53d07b
Author: Pengcheng Xiong <px...@apache.org>
Authored: Sun Jul 30 11:39:04 2017 -0700
Committer: Pengcheng Xiong <px...@apache.org>
Committed: Sun Jul 30 11:39:04 2017 -0700
----------------------------------------------------------------------
.../metastore/TestHiveMetaStoreStatsMerge.java | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hive/blob/483ac74d/itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreStatsMerge.java
----------------------------------------------------------------------
diff --git a/itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreStatsMerge.java b/itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreStatsMerge.java
index 600aef4..234cd29 100644
--- a/itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreStatsMerge.java
+++ b/itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreStatsMerge.java
@@ -26,6 +26,8 @@ import java.util.Map;
import junit.framework.TestCase;
import org.apache.hadoop.hive.cli.CliSessionState;
+import org.apache.hadoop.hive.common.ndv.hll.HyperLogLog;
+import org.apache.hadoop.hive.common.ndv.hll.HyperLogLog.HyperLogLogBuilder;
import org.apache.hadoop.hive.conf.HiveConf;
import org.apache.hadoop.hive.metastore.api.ColumnStatistics;
import org.apache.hadoop.hive.metastore.api.ColumnStatisticsData;
@@ -153,7 +155,12 @@ public class TestHiveMetaStoreStatsMerge extends TestCase {
scsd.setMaxColLen(20);
scsd.setNumNulls(30);
scsd.setNumDVs(123);
- scsd.setBitVectors("{0, 4, 5, 7}{0, 1}{0, 1, 2}{0, 1, 4}{0}{0, 2}{0, 3}{0, 2, 3, 4}{0, 1, 4}{0, 1}{0}{0, 1, 3, 8}{0, 2}{0, 2}{0, 9}{0, 1, 4}");
+ HyperLogLog hll = HyperLogLog.builder().build();
+ hll.addString("a");
+ hll.addString("b");
+ hll.addString("c");
+ hll.addString("c");
+ scsd.setBitVectors(hll.serialize());
data.setStringStats(scsd);
obj.setStatsData(data);
cs.addToStatsObj(obj);
@@ -177,7 +184,12 @@ public class TestHiveMetaStoreStatsMerge extends TestCase {
scsd.setMaxColLen(5);
scsd.setNumNulls(70);
scsd.setNumDVs(456);
- scsd.setBitVectors("{0, 1}{0, 1}{1, 2, 4}{0, 1, 2}{0, 1, 2}{0, 2}{0, 1, 3, 4}{0, 1}{0, 1}{3, 4, 6}{2}{0, 1}{0, 3}{0}{0, 1}{0, 1, 4}");
+ hll = HyperLogLog.builder().build();
+ hll.addString("d");
+ hll.addString("d");
+ hll.addString("c");
+ hll.addString("c");
+ scsd.setBitVectors(hll.serialize());
data.setStringStats(scsd);
obj.setStatsData(data);
cs.addToStatsObj(obj);
@@ -191,8 +203,8 @@ public class TestHiveMetaStoreStatsMerge extends TestCase {
assertEquals(getScsd.getAvgColLen(), 20.0);
assertEquals(getScsd.getMaxColLen(), 20);
assertEquals(getScsd.getNumNulls(), 100);
- // since metastore is ObjectStore, we use the max function to merge.
- assertEquals(getScsd.getNumDVs(), 456);
+ // since metastore is ObjectStore, we use the bitvector to merge.
+ assertEquals(getScsd.getNumDVs(), 4);
}