You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/26 02:46:07 UTC
[GitHub] [pulsar] kristi opened a new pull request #7667: [docs] Use `minikube service` to expose ports
kristi opened a new pull request #7667:
URL: https://github.com/apache/pulsar/pull/7667
### Motivation
I was doing the kubernetes getting started tutorial, and got stuck when trying to connect to the pulsar-mini-proxy service. I realized I needed to run `minikube service pulsar-mini-proxy -n pulsar` in order to expose the service ports outside of minikube.
Environment: OSX Catalina 10.15.3 with minikube v1.12.1 using kubernetes 1.18.3 with docker driver
### Modifications
documentation update for kubernetes getting started tutorial
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy merged pull request #7667: [docs] Use `minikube service` to expose ports
Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #7667:
URL: https://github.com/apache/pulsar/pull/7667
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on pull request #7667: [docs] Use `minikube service` to expose ports
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #7667:
URL: https://github.com/apache/pulsar/pull/7667#issuecomment-665569284
The content has been added since v2.5.0. So it adopts to all versions since v2.5.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] kristi commented on pull request #7667: [docs] Use `minikube service` to expose ports
Posted by GitBox <gi...@apache.org>.
kristi commented on pull request #7667:
URL: https://github.com/apache/pulsar/pull/7667#issuecomment-665126193
thanks for the review, I merged your comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang removed a comment on pull request #7667: [docs] Use `minikube service` to expose ports
Posted by GitBox <gi...@apache.org>.
Jennifer88huang removed a comment on pull request #7667:
URL: https://github.com/apache/pulsar/pull/7667#issuecomment-665498593
Hi @kristi, thank you very much for your contribution. I found an issue with it. This file is not displayed anywhere on [Pulsar doc website](http://pulsar.apache.org/docs/en/next/standalone/). The content here is similar to [Get started in Kubernetes](http://pulsar.apache.org/docs/en/next/kubernetes-helm/). Could you please check which file do you updates will apply? Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #7667: [docs] Use `minikube service` to expose ports
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on a change in pull request #7667:
URL: https://github.com/apache/pulsar/pull/7667#discussion_r461376285
##########
File path: site2/docs/getting-started-helm.md
##########
@@ -200,7 +200,7 @@ We use [Minikube](https://kubernetes.io/docs/getting-started-guides/minikube/) i
You can use the Pulsar client to create producers and consumers to produce and consume messages.
-By default, the Pulsar Helm chart exposes the Pulsar cluster through a Kubernetes `LoadBalancer`. In Minikube, you can use the following command to get the IP address of the proxy service.
+By default, the Pulsar Helm chart exposes the Pulsar cluster through a Kubernetes `LoadBalancer`. In Minikube, you can use the following command to view the proxy service.
Review comment:
```suggestion
By default, the Pulsar Helm chart exposes the Pulsar cluster through a Kubernetes `LoadBalancer`. In Minikube, you can use the following command to check the proxy service.
```
##########
File path: site2/docs/getting-started-helm.md
##########
@@ -212,19 +212,36 @@ You will see a similar output as below.
pulsar-mini-proxy LoadBalancer 10.97.240.109 <pending> 80:32305/TCP,6650:31816/TCP 28m
```
-This output tells what are the node ports that Pulsar cluster's binary port and HTTP port are exposed to. The port after `80:` is the HTTP port while the port after `6650:` is the binary port.
+This output tells what are the node ports that Pulsar cluster's binary port and HTTP port are mapped to. The port after `80:` is the HTTP port while the port after `6650:` is the binary port.
-Then you can find the IP address of your Minikube server by running the following command.
+Then you can find the IP address and exposed ports of your Minikube server by running the following command.
```bash
-minikube ip
+minikube service pulsar-mini-proxy -n pulsar
```
-At this point, you can get the service URLs to connect to your Pulsar client.
+Example output which shows the exposed ip and ports in the second table
Review comment:
```suggestion
**Output**
```
##########
File path: site2/docs/getting-started-helm.md
##########
@@ -212,19 +212,36 @@ You will see a similar output as below.
pulsar-mini-proxy LoadBalancer 10.97.240.109 <pending> 80:32305/TCP,6650:31816/TCP 28m
```
-This output tells what are the node ports that Pulsar cluster's binary port and HTTP port are exposed to. The port after `80:` is the HTTP port while the port after `6650:` is the binary port.
+This output tells what are the node ports that Pulsar cluster's binary port and HTTP port are mapped to. The port after `80:` is the HTTP port while the port after `6650:` is the binary port.
-Then you can find the IP address of your Minikube server by running the following command.
+Then you can find the IP address and exposed ports of your Minikube server by running the following command.
```bash
-minikube ip
+minikube service pulsar-mini-proxy -n pulsar
```
-At this point, you can get the service URLs to connect to your Pulsar client.
+Example output which shows the exposed ip and ports in the second table
+```bash
+|-----------|-------------------|-------------|-------------------------|
+| NAMESPACE | NAME | TARGET PORT | URL |
+|-----------|-------------------|-------------|-------------------------|
+| pulsar | pulsar-mini-proxy | http/80 | http://172.17.0.4:32305 |
+| | | pulsar/6650 | http://172.17.0.4:31816 |
+|-----------|-------------------|-------------|-------------------------|
+🏃 Starting tunnel for service pulsar-mini-proxy.
+|-----------|-------------------|-------------|------------------------|
+| NAMESPACE | NAME | TARGET PORT | URL |
+|-----------|-------------------|-------------|------------------------|
+| pulsar | pulsar-mini-proxy | | http://127.0.0.1:61853 |
+| | | | http://127.0.0.1:61854 |
+|-----------|-------------------|-------------|------------------------|
+```
+
+At this point, you can get the service URLs to connect to your Pulsar client. Urls for this example:
Review comment:
```suggestion
At this point, you can get the service URLs to connect to your Pulsar client. Here are URL examples:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #7667: [docs] Use `minikube service` to expose ports
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7667:
URL: https://github.com/apache/pulsar/pull/7667#issuecomment-665406698
@Huanli-Meng Maybe we need to update this change in other version docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org