You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Christofer Dutz <ch...@c-ware.de> on 2015/04/04 18:48:20 UTC
[DISCUSS] Release Apache Flex Mavenizer 1.0.0
This is the discussion thread to the Apache Flex Mavenizer 1.0.0 vote thread.
Chris
Re: [DISCUSS] Release Apache Flex Mavenizer 1.0.0
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Argh ... sorry for the early VOTE thread ... forgott about that. Will try to do it right next time.
No harm done you can easily cancel it (if it's needed).
Thanks,
Justin
AW: [DISCUSS] Release Apache Flex Mavenizer 1.0.0
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Alex,
you were right. The readme was still refering to the paths of the last Version.
I updated the documentation and will try the "downloaders" again with all the versions we have ... just to make sure. So I'll cancel the vote. But feel free to check my latest changes to the Notice (Year) and the Readme which should now match the refactoring.
Chris
-----Ursprüngliche Nachricht-----
Von: Alex Harui [mailto:aharui@adobe.com]
Gesendet: Montag, 6. April 2015 07:45
An: dev@flex.apache.org
Betreff: Re: [DISCUSS] Release Apache Flex Mavenizer 1.0.0
On 4/5/15, 4:10 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>> Regarding the "tukaani" package. It's a dependency of the
>>apache-commons compress library.
>
>It also not bundled in the source so there no need to modify the
>LICENCE or NOTICE for the source package.
I wasn’t suggesting a LICENSE or NOTICE change. Bundled or not, if there was GNU licensing in a required dependency that would have been a problem.
>
>> But on the Apache Commons page it says it's Public Domain
>>(http://commons.apache.org/proper/commons-compress/dependencies.html)
>
>Looks to be public domain to me [1]
Works for me. It wasn’t clear to me what parts were being used.
>
>Thanks,
>Justin
>
>1. http://tukaani.org/xz/java.html (bottom of the page)
Re: [DISCUSS] Release Apache Flex Mavenizer 1.0.0
Posted by Alex Harui <ah...@adobe.com>.
On 4/5/15, 4:10 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>> Regarding the "tukaani" package. It's a dependency of the
>>apache-commons compress library.
>
>It also not bundled in the source so there no need to modify the LICENCE
>or NOTICE for the source package.
I wasn’t suggesting a LICENSE or NOTICE change. Bundled or not, if there
was GNU licensing in a required dependency that would have been a problem.
>
>> But on the Apache Commons page it says it's Public Domain
>>(http://commons.apache.org/proper/commons-compress/dependencies.html)
>
>Looks to be public domain to me [1]
Works for me. It wasn’t clear to me what parts were being used.
>
>Thanks,
>Justin
>
>1. http://tukaani.org/xz/java.html (bottom of the page)
Re: [DISCUSS] Release Apache Flex Mavenizer 1.0.0
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Regarding the "tukaani" package. It's a dependency of the apache-commons compress library.
It also not bundled in the source so there no need to modify the LICENCE or NOTICE for the source package.
> But on the Apache Commons page it says it's Public Domain (http://commons.apache.org/proper/commons-compress/dependencies.html)
Looks to be public domain to me [1]
Thanks,
Justin
1. http://tukaani.org/xz/java.html (bottom of the page)
AW: [DISCUSS] Release Apache Flex Mavenizer 1.0.0
Posted by Christofer Dutz <ch...@c-ware.de>.
Argh ... sorry for the early VOTE thread ... forgott about that. Will try to do it right next time.
Regarding the "tukaani" package. It's a dependency of the apache-commons compress library. I doubt there should be any problems with it. Probably I could even try to exclude it if this is nessecary. But on the Apache Commons page it says it's Public Domain (http://commons.apache.org/proper/commons-compress/dependencies.html)
Chris
-----Ursprüngliche Nachricht-----
Von: Alex Harui [mailto:aharui@adobe.com]
Gesendet: Sonntag, 5. April 2015 08:33
An: dev@flex.apache.org
Betreff: Re: [DISCUSS] Release Apache Flex Mavenizer 1.0.0
Hi Chris,
Looks pretty good. IMO, in the new release process you would not have started a vote thread until we got a chance to pick through the source package. Then I’d be more tempted to fix minor stuff in the README and other docs. Once a vote is under way I’m less likely to do so.
Anyway, the only question I have is about the use of the tukaani package.
The licensing says that some parts of it are under GNU licenses. Can I assume we aren’t using those parts?
Other than that, I’ll try to actually run it tomorrow or Monday, then I’m good to go.
-Alex
On 4/4/15, 9:48 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>This is the discussion thread to the Apache Flex Mavenizer 1.0.0 vote
>thread.
>
>
>Chris
Re: [DISCUSS] Release Apache Flex Mavenizer 1.0.0
Posted by Alex Harui <ah...@adobe.com>.
Hi Chris,
Looks pretty good. IMO, in the new release process you would not have
started a vote thread until we got a chance to pick through the source
package. Then I’d be more tempted to fix minor stuff in the README and
other docs. Once a vote is under way I’m less likely to do so.
Anyway, the only question I have is about the use of the tukaani package.
The licensing says that some parts of it are under GNU licenses. Can I
assume we aren’t using those parts?
Other than that, I’ll try to actually run it tomorrow or Monday, then I’m
good to go.
-Alex
On 4/4/15, 9:48 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>This is the discussion thread to the Apache Flex Mavenizer 1.0.0 vote
>thread.
>
>
>Chris
AW: [DISCUSS] Release Apache Flex Mavenizer 1.0.0
Posted by Christofer Dutz <ch...@c-ware.de>.
Well the entire converter is split up into several modules.
- The API modules (converter, retriever, deployer)
- The implementation modules for each of these.
- The core module, which puts them all together.
That's why the flex-sdk-converter-1.0.jar is located in /core/target/flex-sdk-converter-1.0.0.jar so I could adjust the documentation for this. The outter module is simply a project wrapping all together and doesn't really contain any sensible output.
Anyway the main purpose of this utility is to produce the flex-sdk-converter-1.0.0.jar but it's main purpose is to deliver the functionality, so I can include this in Flexmojos. I doubt a lot of people will actually be using it at all directly cause meant to become part of the tooling.
Chris
-----Ursprüngliche Nachricht-----
Von: Justin Mclean [mailto:justinmclean@me.com]
Gesendet: Sonntag, 5. April 2015 01:45
An: dev@flex.apache.org
Betreff: Re: [DISCUSS] Release Apache Flex Mavenizer 1.0.0
Hi,
Everything looks good to me (LICENCE and NOTICE, no binary files, all source code has headers, compiles from source, pom looks good etc etc). Only one very minor issue wrong year in NOTICE file (2014 rather than 2015).
Enough to give it a +1 vote IMO but I'm not sure how to use or test what is produced.
I think the README.txt need to be updated a little, it says to do this:
java -cp target/flex-sdk-converter-1.0.jar SDKGenerator "{sdkhome}" "{fdktarget}"
When I think the jar may be this one?
./converters/flex/target/flex-converter-1.0.0.jar
And while I can compile everything and it gives "SUCCESS" the target directory is mostly empty:
ls -R target
maven-shared-archive-resources
target/maven-shared-archive-resources:
META-INF
target/maven-shared-archive-resources/META-INF:
DEPENDENCIES LICENSE NOTICE
But I do get other jars:
find . -name "*.jar" -print
./converters/air/target/air-converter-1.0.0.jar
./converters/base/target/base-converter-1.0.0.jar
./converters/flash/target/flash-converter-1.0.0.jar
./converters/flex/target/flex-converter-1.0.0.jar
./core/target/core-1.0.0.jar
./core/target/flex-sdk-converter-1.0.0.jar
./deployers/aether/target/aether-deployer-1.0.0-full.jar
./deployers/aether/target/aether-deployer-1.0.0.jar
./deployers/maven/target/maven-deployer-1.0.0-full.jar
./deployers/maven/target/maven-deployer-1.0.0.jar
./mavenizer/target/mavenizer-1.0.0.jar
./mavenizer/target/mavenizer.jar
./mavenizer/target/original-mavenizer.jar
./retrievers/base/target/base-retriever-1.0.0.jar
./retrievers/download/target/download-retriever-1.0.0.jar
Is this expected?
Thanks,
Justin
Re: [DISCUSS] Release Apache Flex Mavenizer 1.0.0
Posted by Justin Mclean <ju...@me.com>.
Hi,
Everything looks good to me (LICENCE and NOTICE, no binary files, all source code has headers, compiles from source, pom looks good etc etc). Only one very minor issue wrong year in NOTICE file (2014 rather than 2015).
Enough to give it a +1 vote IMO but I'm not sure how to use or test what is produced.
I think the README.txt need to be updated a little, it says to do this:
java -cp target/flex-sdk-converter-1.0.jar SDKGenerator "{sdkhome}" "{fdktarget}"
When I think the jar may be this one?
./converters/flex/target/flex-converter-1.0.0.jar
And while I can compile everything and it gives "SUCCESS" the target directory is mostly empty:
ls -R target
maven-shared-archive-resources
target/maven-shared-archive-resources:
META-INF
target/maven-shared-archive-resources/META-INF:
DEPENDENCIES LICENSE NOTICE
But I do get other jars:
find . -name "*.jar" -print
./converters/air/target/air-converter-1.0.0.jar
./converters/base/target/base-converter-1.0.0.jar
./converters/flash/target/flash-converter-1.0.0.jar
./converters/flex/target/flex-converter-1.0.0.jar
./core/target/core-1.0.0.jar
./core/target/flex-sdk-converter-1.0.0.jar
./deployers/aether/target/aether-deployer-1.0.0-full.jar
./deployers/aether/target/aether-deployer-1.0.0.jar
./deployers/maven/target/maven-deployer-1.0.0-full.jar
./deployers/maven/target/maven-deployer-1.0.0.jar
./mavenizer/target/mavenizer-1.0.0.jar
./mavenizer/target/mavenizer.jar
./mavenizer/target/original-mavenizer.jar
./retrievers/base/target/base-retriever-1.0.0.jar
./retrievers/download/target/download-retriever-1.0.0.jar
Is this expected?
Thanks,
Justin