You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2018/02/23 17:31:50 UTC

svn commit: r1825142 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

Author: markt
Date: Fri Feb 23 17:31:49 2018
New Revision: 1825142

URL: http://svn.apache.org/viewvc?rev=1825142&view=rev
Log:
Fix some false positives

Modified:
    tomcat/trunk/res/findbugs/filter-false-positives.xml

Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1825142&r1=1825141&r2=1825142&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Fri Feb 23 17:31:49 2018
@@ -291,6 +291,18 @@
     <Bug code="REC" />
   </Match>
   <Match>
+    <!-- The fields are only set in setWrapper() which Tomcat calls once during
+         initialisation. All other accesses are reads. -->
+    <Or>
+      <Field name="context" />
+      <Field name="host" />
+      <Field name="mBeanServer" />
+      <Field name="oname" />
+      <Field name="wrapper" />
+    </Or>
+    <Bug pattern="MSF_MUTABLE_SERVLET_FIELD" />
+  </Match>
+  <Match>
     <!-- SQL construction is safe since it is from trusted config -->
     <Or>
       <Class name="org.apache.catalina.realm.DataSourceRealm" />



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org