You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by mindprince <gi...@git.apache.org> on 2015/08/25 23:50:50 UTC

[GitHub] incubator-zeppelin pull request: ZEPPELIN-263: Don't pass Exceptio...

GitHub user mindprince opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/259

    ZEPPELIN-263: Don't pass Exception objects to JsonResponse.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mindprince/incubator-zeppelin ZEPPELIN-263

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/259.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #259
    
----
commit 47f719c969642076d9fb87ee345a674aa7d2802f
Author: Rohit Agarwal <ro...@qubole.com>
Date:   2015-08-25T21:50:16Z

    ZEPPELIN-263: Don't pass Exception objects to JsonResponse.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-263: Don't pass Exceptio...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/259


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-263: Don't pass Exceptio...

Posted by mindprince <gi...@git.apache.org>.
Github user mindprince commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/259#issuecomment-135140040
  
    To check the effect of this PR:
    ```
    $ curl -i -d '{}' -X PUT localhost:8080/api/interpreter/setting/asdf
    ```
    
    Before:
    ```
    HTTP/1.1 500 Server Error
    Access-Control-Allow-Origin:
    Access-Control-Allow-Credentials: true
    Access-Control-Allow-Headers: authorization,Content-Type
    Access-Control-Allow-Methods: POST, GET, OPTIONS, PUT, HEAD, DELETE
    Date: Wednesday, August 26, 2015 11:59:00 AM PDT
    Cache-Control: must-revalidate,no-cache,no-store
    Content-Type: text/html;charset=ISO-8859-1
    Content-Length: 1301
    Server: Jetty(8.1.14.v20131031)
    
    <html>
    <head>
    <meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1"/>
    <title>Error 500 Server Error</title>
    </head>
    <body>
    <h2>HTTP ERROR: 500</h2>
    <p>Problem accessing /api/interpreter/setting/asdf. Reason:
    <pre>    Server Error</pre></p>
    <hr /><i><small>Powered by Jetty://</small></i>
    
    </body>
    </html>
    ```
    After:
    ```
    HTTP/1.1 404 Not Found
    Access-Control-Allow-Origin:
    Access-Control-Allow-Credentials: true
    Access-Control-Allow-Headers: authorization,Content-Type
    Access-Control-Allow-Methods: POST, GET, OPTIONS, PUT, HEAD, DELETE
    Date: Wednesday, August 26, 2015 11:54:29 AM PDT
    Content-Type: application/json
    Date: Wed, 26 Aug 2015 18:54:29 GMT
    Content-Length: 86
    Server: Jetty(8.1.14.v20131031)
    
    {"status":"NOT_FOUND","message":"Interpreter setting id asdf not found","body":"asdf"}
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-263: Don't pass Exceptio...

Posted by mindprince <gi...@git.apache.org>.
Github user mindprince commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/259#issuecomment-135870346
  
    @Leemoonsoo Can this be merged now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-263: Don't pass Exceptio...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/259#issuecomment-135882888
  
    @mindprince Let's merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---