[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499949#comment-16499949 ] 

Hadoop QA commented on ZOOKEEPER-3019:
--------------------------------------

-1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1784//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1784//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1784//console

This message is automatically generated.

> Add a metric to track number of slow fsyncs
> -------------------------------------------
>
>                 Key: ZOOKEEPER-3019
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: jmx, server
>    Affects Versions: 3.5.3, 3.4.11, 3.6.0
>            Reporter: Norbert Kalmar
>            Assignee: Norbert Kalmar
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.6.0, 3.4.13, 3.5.5
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceeds fsyncWarningThresholdMS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)