You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2020/12/08 10:14:03 UTC

svn commit: r1884201 - in /pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox: pdmodel/interactive/form/ControlCharacterTest.java rendering/TestRendering.java

Author: msahyoun
Date: Tue Dec  8 10:14:02 2020
New Revision: 1884201

URL: http://svn.apache.org/viewvc?rev=1884201&view=rev
Log:
PDFBOX-4892: add basic test

Modified:
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/ControlCharacterTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/ControlCharacterTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/ControlCharacterTest.java?rev=1884201&r1=1884200&r2=1884201&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/ControlCharacterTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/ControlCharacterTest.java Tue Dec  8 10:14:02 2020
@@ -76,15 +76,27 @@ class ControlCharacterTest
     @Test
     void characterNUL() throws IOException
     {
+        PDField field = acroForm.getField("pdfbox-nul");
         assertThrows(IllegalArgumentException.class, () -> {
-            acroForm.getField("pdfbox-nul").setValue("NUL\0NUL");
+            field.setValue("NUL\0NUL");
           });
     }
 
+    /*
+     * No direct comparison to how Acrobat sets the value
+     * as we don't position with tabs.
+     */
     @Test
     void characterTAB() throws IOException
     {
-    	acroForm.getField("pdfbox-tab").setValue("TAB\tTAB");
+        PDField field = acroForm.getField("pdfbox-tab");
+    	field.setValue("TAB\tTAB");
+
+        List<String> pdfboxValues = getStringsFromStream(field);
+        for (String token : pdfboxValues)
+        {
+            assertEquals("TAB", token);
+        }
     }
     
     @Test

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java?rev=1884201&r1=1884200&r2=1884201&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java Tue Dec  8 10:14:02 2020
@@ -25,6 +25,7 @@ import org.junit.jupiter.params.provider
 import org.junit.jupiter.api.parallel.Execution;
 import org.junit.jupiter.api.parallel.ExecutionMode;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.fail;
 
 import java.io.File;
@@ -69,13 +70,13 @@ public class TestRendering
         File file = new File(INPUT_DIR, fileName);
         PDDocument document = Loader.loadPDF(file);
         PDFRenderer renderer = new PDFRenderer(document);
-        renderer.renderImage(0);
-
+        
         // We don't actually do anything with the image for the same reason that
         // TestPDFToImage is disabled - different JVMs produce different results
         // but at least we can make sure that PDFBox did not throw any exceptions
         // during the rendering process.
 
+        assertDoesNotThrow(() -> renderer.renderImage(0));
         document.close();
     }