You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/05/03 19:48:22 UTC
Review Request 70573: Updated bintray upload scripts to remove
hard-coded accounts.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70573/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Bugs: MESOS-9697
https://issues.apache.org/jira/browse/MESOS-9697
Repository: mesos
Description
-------
This updates the Jenkinsfile used in the ASF Jenkins as well
as the associated upload script for bintray to make the
used credential id configurable and to upload the built packages
to the official `apache/mesos` bintray account.
Diffs
-----
support/packaging/Jenkinsfile 7446b2b8b88df6c146f4415b06dda227ca8ce631
support/packaging/bintray.sh 4f1795f14b078e8eebe95aaa40cf860d6d19ee97
Diff: https://reviews.apache.org/r/70573/diff/1/
Testing
-------
Not sure how to test jenkins pipelines :/
Thanks,
Benno Evers
Re: Review Request 70573: Updated bintray upload scripts to remove
hard-coded accounts.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70573/#review215322
-----------------------------------------------------------
Ship it!
Looks sane.
And I see that any process changes will be documented here: https://reviews.apache.org/r/70528/
- Joseph Wu
On May 3, 2019, 12:48 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70573/
> -----------------------------------------------------------
>
> (Updated May 3, 2019, 12:48 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9697
> https://issues.apache.org/jira/browse/MESOS-9697
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This updates the Jenkinsfile used in the ASF Jenkins as well
> as the associated upload script for bintray to make the
> used credential id configurable and to upload the built packages
> to the official `apache/mesos` bintray account.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile 7446b2b8b88df6c146f4415b06dda227ca8ce631
> support/packaging/bintray.sh 4f1795f14b078e8eebe95aaa40cf860d6d19ee97
>
>
> Diff: https://reviews.apache.org/r/70573/diff/1/
>
>
> Testing
> -------
>
> Not sure how to test jenkins pipelines :/
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70573: Updated bintray upload scripts to remove
hard-coded accounts.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70573/#review215048
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70573]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 3, 2019, 7:48 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70573/
> -----------------------------------------------------------
>
> (Updated May 3, 2019, 7:48 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9697
> https://issues.apache.org/jira/browse/MESOS-9697
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This updates the Jenkinsfile used in the ASF Jenkins as well
> as the associated upload script for bintray to make the
> used credential id configurable and to upload the built packages
> to the official `apache/mesos` bintray account.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile 7446b2b8b88df6c146f4415b06dda227ca8ce631
> support/packaging/bintray.sh 4f1795f14b078e8eebe95aaa40cf860d6d19ee97
>
>
> Diff: https://reviews.apache.org/r/70573/diff/1/
>
>
> Testing
> -------
>
> Not sure how to test jenkins pipelines :/
>
>
> Thanks,
>
> Benno Evers
>
>