You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/08 15:56:38 UTC
[GitHub] [kafka] wenbingshen commented on a change in pull request #10841: KAFKA-12482 Remove deprecated rest.host.name and rest.port configs
wenbingshen commented on a change in pull request #10841:
URL: https://github.com/apache/kafka/pull/10841#discussion_r647551596
##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java
##########
@@ -146,25 +146,6 @@
+ "data to be committed in a future attempt.";
public static final long OFFSET_COMMIT_TIMEOUT_MS_DEFAULT = 5000L;
- /**
- * @deprecated As of 1.1.0. Only used when listeners is not set. Use listeners instead.
- */
- @Deprecated
- public static final String REST_HOST_NAME_CONFIG = "rest.host.name";
Review comment:
Should we add a description about removing this option in the upgrade document?
##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java
##########
@@ -146,25 +146,6 @@
+ "data to be committed in a future attempt.";
public static final long OFFSET_COMMIT_TIMEOUT_MS_DEFAULT = 5000L;
- /**
- * @deprecated As of 1.1.0. Only used when listeners is not set. Use listeners instead.
- */
- @Deprecated
- public static final String REST_HOST_NAME_CONFIG = "rest.host.name";
- private static final String REST_HOST_NAME_DOC
- = "Hostname for the REST API. If this is set, it will only bind to this interface.\n" +
- "Deprecated, only used when listeners is not set. Use listeners instead.";
-
- /**
- * @deprecated As of 1.1.0. Only used when listeners is not set. Use listeners instead.
- */
- @Deprecated
- public static final String REST_PORT_CONFIG = "rest.port";
Review comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org