[GitHub] [cassandra] jonmeredith commented on a change in pull request #868: CASSANDRA-16385

[GitBox <gi...@apache.org>]

jonmeredith commented on a change in pull request #868:
URL: https://github.com/apache/cassandra/pull/868#discussion_r568152496



##########
File path: test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java
##########
@@ -177,6 +178,10 @@ public void run() throws Throwable
                             cluster.get(n).shutdown().get();
                             cluster.get(n).setVersion(version);
                             cluster.get(n).startup();
+                            // If using in-jvm Dtest networking, update the messaging versions
+                            // so that message filters are able to serialize/deserialize correctly.
+                            if (!cluster.get(n).config().has(Feature.NETWORK))
+                                cluster.updateMessagingVersions();

Review comment:
       I'd missed that and made this change to make sure the messaging version was set on upgrade. I added the guard around the NETWORK feature so as not to affect any version negotiation attempts if using real networking.
   
   It's probably safest to leave it alone. I'll remove from my code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org