You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/25 17:00:15 UTC

[GitHub] [incubator-superset] bkyryliuk opened a new pull request #11066: fix: fix table existence validation function [WIP]

bkyryliuk opened a new pull request #11066:
URL: https://github.com/apache/incubator-superset/pull/11066


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #11066: fix: fix table existence validation function

Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #11066:
URL: https://github.com/apache/incubator-superset/pull/11066#discussion_r496240960



##########
File path: superset/connectors/sqla/models.py
##########
@@ -453,7 +453,7 @@ class SqlaTable(  # pylint: disable=too-many-public-methods,too-many-instance-at
     owner_class = security_manager.user_model
 
     __tablename__ = "tables"
-    __table_args__ = (UniqueConstraint("database_id", "table_name"),)
+    __table_args__ = (UniqueConstraint("database_id", "schema", "table_name"),)

Review comment:
       @john-bodley - do you know if there are any issues with changing __table_args__ here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #11066: fix: fix table existence validation function

Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #11066:
URL: https://github.com/apache/incubator-superset/pull/11066#discussion_r496289193



##########
File path: superset/connectors/sqla/models.py
##########
@@ -453,7 +453,7 @@ class SqlaTable(  # pylint: disable=too-many-public-methods,too-many-instance-at
     owner_class = security_manager.user_model
 
     __tablename__ = "tables"
-    __table_args__ = (UniqueConstraint("database_id", "table_name"),)
+    __table_args__ = (UniqueConstraint("database_id", "schema", "table_name"),)

Review comment:
       This will not work per https://github.com/apache/incubator-superset/pull/5449.

##########
File path: superset/connectors/sqla/models.py
##########
@@ -453,7 +453,7 @@ class SqlaTable(  # pylint: disable=too-many-public-methods,too-many-instance-at
     owner_class = security_manager.user_model
 
     __tablename__ = "tables"
-    __table_args__ = (UniqueConstraint("database_id", "table_name"),)
+    __table_args__ = (UniqueConstraint("database_id", "schema", "table_name"),)

Review comment:
       @bkyryliuk this will not work per https://github.com/apache/incubator-superset/pull/5449.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk merged pull request #11066: fix: fix table existence validation function

Posted by GitBox <gi...@apache.org>.
bkyryliuk merged pull request #11066:
URL: https://github.com/apache/incubator-superset/pull/11066


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #11066: fix: fix table existence validation function

Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #11066:
URL: https://github.com/apache/incubator-superset/pull/11066#discussion_r496307258



##########
File path: superset/connectors/sqla/models.py
##########
@@ -453,7 +453,7 @@ class SqlaTable(  # pylint: disable=too-many-public-methods,too-many-instance-at
     owner_class = security_manager.user_model
 
     __tablename__ = "tables"
-    __table_args__ = (UniqueConstraint("database_id", "table_name"),)
+    __table_args__ = (UniqueConstraint("database_id", "schema", "table_name"),)

Review comment:
       thanks @john-bodley, reverted this line




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org