You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by GitBox <gi...@apache.org> on 2021/09/13 18:54:25 UTC
[GitHub] [bahir-flink] rmetzger opened a new pull request #125: [BAHIR-XXX] Remove flink-library-siddhi
rmetzger opened a new pull request #125:
URL: https://github.com/apache/bahir-flink/pull/125
See https://issues.apache.org/jira/browse/BAHIR-280 + dev@bahir list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] rmetzger commented on pull request #125: [BAHIR-280] Remove flink-library-siddhi
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #125:
URL: https://github.com/apache/bahir-flink/pull/125#issuecomment-922266406
Cool, thanks a lot. This change seems reasonable, certainly better than just dropping a contribution.
I'm closing this PR and opening one for your branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] eskabetxe edited a comment on pull request #125: [BAHIR-280] Remove flink-library-siddhi
Posted by GitBox <gi...@apache.org>.
eskabetxe edited a comment on pull request #125:
URL: https://github.com/apache/bahir-flink/pull/125#issuecomment-919230870
@rmetzger I try to update to last version, and basically I only have to change the packages
I have some doubt about this testing class CustomPlusFunctionExtension, but all testings are working
could you check
https://github.com/eskabetxe/bahir-flink/tree/BAHIR-280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] rmetzger closed pull request #125: [BAHIR-280] Remove flink-library-siddhi
Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #125:
URL: https://github.com/apache/bahir-flink/pull/125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] eskabetxe commented on pull request #125: [BAHIR-280] Remove flink-library-siddhi
Posted by GitBox <gi...@apache.org>.
eskabetxe commented on pull request #125:
URL: https://github.com/apache/bahir-flink/pull/125#issuecomment-919230870
@rmetzger I try to update to last version, and basically I only have to change the packages
I have some doubt about this class CustomPlusFunctionExtension, but all testings are working
could you check
https://github.com/eskabetxe/bahir-flink/tree/BAHIR-280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org