You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uniffle.apache.org by ro...@apache.org on 2024/02/28 11:10:32 UTC
(incubator-uniffle) branch master updated: [#1549] fix(common): Uniformly throw RssException for external callers (#1550)
This is an automated email from the ASF dual-hosted git repository.
roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new d4c0fc583 [#1549] fix(common): Uniformly throw RssException for external callers (#1550)
d4c0fc583 is described below
commit d4c0fc583b6b163585d28dc65c51248f4c43b127
Author: RickyMa <ri...@tencent.com>
AuthorDate: Wed Feb 28 19:10:27 2024 +0800
[#1549] fix(common): Uniformly throw RssException for external callers (#1550)
### What changes were proposed in this pull request?
Make custom exception classes in the `rss-common` module inherit from `RssException`.
### Why are the changes needed?
For https://github.com/apache/incubator-uniffle/issues/1549
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing UTs.
---
.../java/org/apache/uniffle/common/exception/FileNotFoundException.java | 2 +-
.../org/apache/uniffle/common/exception/InvalidRequestException.java | 2 +-
.../java/org/apache/uniffle/common/exception/NoBufferException.java | 2 +-
.../uniffle/common/exception/NoBufferForHugePartitionException.java | 2 +-
.../java/org/apache/uniffle/common/exception/NoRegisterException.java | 2 +-
.../org/apache/uniffle/common/exception/RssSendFailedException.java | 2 +-
.../org/apache/uniffle/common/exception/RssWaitFailedException.java | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/common/src/main/java/org/apache/uniffle/common/exception/FileNotFoundException.java b/common/src/main/java/org/apache/uniffle/common/exception/FileNotFoundException.java
index b7d1a34b5..36df32073 100644
--- a/common/src/main/java/org/apache/uniffle/common/exception/FileNotFoundException.java
+++ b/common/src/main/java/org/apache/uniffle/common/exception/FileNotFoundException.java
@@ -17,7 +17,7 @@
package org.apache.uniffle.common.exception;
-public class FileNotFoundException extends RuntimeException {
+public class FileNotFoundException extends RssException {
public FileNotFoundException(String message) {
super(message);
diff --git a/common/src/main/java/org/apache/uniffle/common/exception/InvalidRequestException.java b/common/src/main/java/org/apache/uniffle/common/exception/InvalidRequestException.java
index ab890c792..7c666a6b0 100644
--- a/common/src/main/java/org/apache/uniffle/common/exception/InvalidRequestException.java
+++ b/common/src/main/java/org/apache/uniffle/common/exception/InvalidRequestException.java
@@ -17,7 +17,7 @@
package org.apache.uniffle.common.exception;
-public class InvalidRequestException extends RuntimeException {
+public class InvalidRequestException extends RssException {
public InvalidRequestException(String message) {
super(message);
diff --git a/common/src/main/java/org/apache/uniffle/common/exception/NoBufferException.java b/common/src/main/java/org/apache/uniffle/common/exception/NoBufferException.java
index 6bf5ca28a..ace96abe9 100644
--- a/common/src/main/java/org/apache/uniffle/common/exception/NoBufferException.java
+++ b/common/src/main/java/org/apache/uniffle/common/exception/NoBufferException.java
@@ -17,7 +17,7 @@
package org.apache.uniffle.common.exception;
-public class NoBufferException extends RuntimeException {
+public class NoBufferException extends RssException {
public NoBufferException(String message) {
super(message);
}
diff --git a/common/src/main/java/org/apache/uniffle/common/exception/NoBufferForHugePartitionException.java b/common/src/main/java/org/apache/uniffle/common/exception/NoBufferForHugePartitionException.java
index df6e36984..76ef2e5b3 100644
--- a/common/src/main/java/org/apache/uniffle/common/exception/NoBufferForHugePartitionException.java
+++ b/common/src/main/java/org/apache/uniffle/common/exception/NoBufferForHugePartitionException.java
@@ -17,7 +17,7 @@
package org.apache.uniffle.common.exception;
-public class NoBufferForHugePartitionException extends RuntimeException {
+public class NoBufferForHugePartitionException extends RssException {
public NoBufferForHugePartitionException(String message) {
super(message);
}
diff --git a/common/src/main/java/org/apache/uniffle/common/exception/NoRegisterException.java b/common/src/main/java/org/apache/uniffle/common/exception/NoRegisterException.java
index 34f72309e..930369d35 100644
--- a/common/src/main/java/org/apache/uniffle/common/exception/NoRegisterException.java
+++ b/common/src/main/java/org/apache/uniffle/common/exception/NoRegisterException.java
@@ -17,7 +17,7 @@
package org.apache.uniffle.common.exception;
-public class NoRegisterException extends RuntimeException {
+public class NoRegisterException extends RssException {
public NoRegisterException(String message) {
super(message);
}
diff --git a/common/src/main/java/org/apache/uniffle/common/exception/RssSendFailedException.java b/common/src/main/java/org/apache/uniffle/common/exception/RssSendFailedException.java
index a1f4679ad..4ae3678fc 100644
--- a/common/src/main/java/org/apache/uniffle/common/exception/RssSendFailedException.java
+++ b/common/src/main/java/org/apache/uniffle/common/exception/RssSendFailedException.java
@@ -17,7 +17,7 @@
package org.apache.uniffle.common.exception;
-public class RssSendFailedException extends RuntimeException {
+public class RssSendFailedException extends RssException {
public RssSendFailedException(String message) {
super(message);
}
diff --git a/common/src/main/java/org/apache/uniffle/common/exception/RssWaitFailedException.java b/common/src/main/java/org/apache/uniffle/common/exception/RssWaitFailedException.java
index 147727e66..e6335bf27 100644
--- a/common/src/main/java/org/apache/uniffle/common/exception/RssWaitFailedException.java
+++ b/common/src/main/java/org/apache/uniffle/common/exception/RssWaitFailedException.java
@@ -17,7 +17,7 @@
package org.apache.uniffle.common.exception;
-public class RssWaitFailedException extends RuntimeException {
+public class RssWaitFailedException extends RssException {
public RssWaitFailedException(String message) {
super(message);
}