You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Küng <to...@gmail.com> on 2006/01/06 21:14:25 UTC
[PATCH] Fix broken SSPI authentication
Hi,
While trying to find out why TortoiseSVN/Subversion couldn't connect to
a repository located on a windows domain anymore if the client wasn't
part of the same domain, I stumbled upon a bug in neon.
The attached patch fixes this. One patch is against trunk, the other
against the 0.25.4 tag.
I've tested the patch with the help of some TortoiseSVN users who
provided me with access to their repositories.
Stefan
(ccing the Subversion dev list, because they might want to include that
patch for their windows binaries build).
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.tigris.org
Re: [PATCH] Fix broken SSPI authentication
Posted by kf...@collab.net.
Stefan Küng <to...@gmail.com> writes:
> please don't use that patch! It doesn't work (well, it makes
> Subversion work again, but by deactivating the SSPI authentication -
> which can be done much easier by using the define).
Thanks for letting me know!
By the way, my original mail to you was private. It contained nothing
controversial, fortunately, but I'd prefer not to have private mails
forwarded to public lists. One possible reading of what I wrote (an
incorrect reading) would be that I somehow expected delay in the
patch's integration into Neon. That's not what I meant, of course,
but if I knew I had been writing for a public list I would have
phrased it differently.
Thanks,
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix broken SSPI authentication
Posted by Stefan Küng <to...@gmail.com>.
Hi Karl,
please don't use that patch! It doesn't work (well, it makes
Subversion work again, but by deactivating the SSPI authentication -
which can be done much easier by using the define).
If you want to use it, please use this patch:
http://mailman.webdav.org/pipermail/neon/2006-January/002157.html
that patch is tested by TSVN users (I've counted 6 users so far which
reported that it works).
Stefan
On 09 Jan 2006 13:46:56 -0600, kfogel@collab.net <kf...@collab.net> wrote:
> [private to you]
>
> Nice job! Let's see how quickly Joe & company integrate it...
>
> Stefan Küng <to...@gmail.com> writes:
> > While trying to find out why TortoiseSVN/Subversion couldn't connect
> > to a repository located on a windows domain anymore if the client
> > wasn't part of the same domain, I stumbled upon a bug in neon.
> > The attached patch fixes this. One patch is against trunk, the other
> > against the 0.25.4 tag.
> >
> > I've tested the patch with the help of some TortoiseSVN users who
> > provided me with access to their repositories.
> >
> > (ccing the Subversion dev list, because they might want to include
> > that patch for their windows binaries build).
> >
> > --
> > ___
> > oo // \\ "De Chelonian Mobile"
> > (_,\/ \_/ \ TortoiseSVN
> > \ \_/_\_/> The coolest Interface to (Sub)Version Control
> > /_/ \_\ http://tortoisesvn.tigris.org
> > Index: src/ne_sspi.c
> > ===================================================================
> > --- src/ne_sspi.c (Revision 831)
> > +++ src/ne_sspi.c (Arbeitskopie)
> > @@ -487,7 +487,7 @@
> > &outBufferDesc);
> > freeBuffer(&inBufferDesc);
> > } else {
> > - if (sspiContext->continueNeeded) {
> > + if (!sspiContext->continueNeeded) {
> > NE_DEBUG(NE_DBG_HTTPAUTH, "sspi: Expected a token from server.\n");
> > return -1;
> > }
> > [[[
> > Fix endless SSPI authentication.
> > * src/ne_sspi.c:
> > Continue authenticating only if requested.
> > ]]]
> > Index: src/ne_sspi.c
> > ===================================================================
> > --- src/ne_sspi.c (Revision 831)
> > +++ src/ne_sspi.c (Arbeitskopie)
> > @@ -487,7 +487,7 @@
> > &outBufferDesc);
> > freeBuffer(&inBufferDesc);
> > } else {
> > - if (sspiContext->continueNeeded) {
> > + if (!sspiContext->continueNeeded) {
> > NE_DEBUG(NE_DBG_HTTPAUTH, "sspi: Expected a token from server.\n");
> > return -1;
> > }
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> > For additional commands, e-mail: dev-help@subversion.tigris.org
>
> --
>
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org