You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Marat Radchenko (JIRA)" <ji...@apache.org> on 2009/12/08 14:15:18 UTC

[jira] Created: (WICKET-2598) Some components still escape non-ASCII symbols by default

Some components still escape non-ASCII symbols by default
---------------------------------------------------------

                 Key: WICKET-2598
                 URL: https://issues.apache.org/jira/browse/WICKET-2598
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.4.3
            Reporter: Marat Radchenko


With fix for WICKET-1054 Wicket (almost) stopped escaping non-ASCII symbols by default, it calls Strings.escapeMarkup(String) or Strings.escapeMarkup(String, false, false).

However, there are still some places that also call Strings.escapeMarkup with different args.

I used "Strings.escapeMarkup\(.*, false, true\)" regex to find them:
AbstractChoice.escapeOptionHtml,
CheckBoxMultipleChoice.onComponentTagBody (the reason i started to dig into this issue)
RadioChoice.onComponentTagBody

They should either call String.escapeMarkup(String) or even use Component.getDefaultModelObjectAsString

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-2598) Some components still escape non-ASCII symbols by default

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-2598.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-M1
                   1.4.5
         Assignee: Juergen Donnerstag

thanks

> Some components still escape non-ASCII symbols by default
> ---------------------------------------------------------
>
>                 Key: WICKET-2598
>                 URL: https://issues.apache.org/jira/browse/WICKET-2598
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.3
>            Reporter: Marat Radchenko
>            Assignee: Juergen Donnerstag
>             Fix For: 1.4.5, 1.5-M1
>
>
> With fix for WICKET-1054 Wicket (almost) stopped escaping non-ASCII symbols by default, it calls Strings.escapeMarkup(String) or Strings.escapeMarkup(String, false, false).
> However, there are still some places that also call Strings.escapeMarkup with different args.
> I used "Strings.escapeMarkup\(.*, false, true\)" regex to find them:
> AbstractChoice.escapeOptionHtml,
> CheckBoxMultipleChoice.onComponentTagBody (the reason i started to dig into this issue)
> RadioChoice.onComponentTagBody
> They should either call String.escapeMarkup(String) or even use Component.getDefaultModelObjectAsString

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.