You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/27 12:01:26 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #2598: Split out integration test plumbing (#2594) (#2300)
tustvold opened a new pull request, #2598:
URL: https://github.com/apache/arrow-rs/pull/2598
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of #2594
Part of #2300
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
The way the integration test plumbing is muddled with the core logic is incredibly confusing, and complicates splitting apart the crates (#2594) and adding features flags (#2300)
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
This moves the integration test plumbing to the existing integration-testing. I originally moved it to a separate crate, but this seemed redundant
# Are there any user-facing changes?
Technically this functionality was being published, it now isn't. I have confirmed DataFusion isn't making use of this.
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2598: Split out integration test plumbing (#2594) (#2300)
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2598:
URL: https://github.com/apache/arrow-rs/pull/2598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2598: Split out integration test plumbing (#2594) (#2300)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2598:
URL: https://github.com/apache/arrow-rs/pull/2598#issuecomment-1229423141
Benchmark runs are scheduled for baseline = 6ab208cf048ef695fcff3b683fad3b6bc58ef428 and contender = c6e76809a33e2e85df25ff5cefad93dc6a4499b8. c6e76809a33e2e85df25ff5cefad93dc6a4499b8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0f701e1df7e6432fa023fafbfda3f7f6...4b6c7a4e0f124e3eb7a9b9c0efd5bd59/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/62d40c1f82f9499883b4367f6e6dc7fd...11b8e83952b847718cc299f080122e1c/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1e0f7c6a21e24b029dd70d5e1f48f7eb...ed443ef60c0f46acb601ec0d40a93234/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4340b8014f6c4127b9591d8ba4077d87...428536ab942547d890cef85373421656/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2598: Split out integration test plumbing (#2594) (#2300)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2598:
URL: https://github.com/apache/arrow-rs/pull/2598#discussion_r956574611
##########
arrow/src/ipc/writer.rs:
##########
@@ -1270,47 +1270,43 @@ mod tests {
use super::*;
use std::fs::File;
- use std::io::Read;
+ use std::io::Seek;
use std::sync::Arc;
- use flate2::read::GzDecoder;
use ipc::MetadataVersion;
use crate::array::*;
use crate::datatypes::Field;
use crate::ipc::reader::*;
- use crate::util::integration_util::*;
#[test]
#[cfg(feature = "ipc_compression")]
fn test_write_empty_record_batch_lz4_compression() {
- let file_name = "arrow_lz4_empty";
let schema = Schema::new(vec![Field::new("field1", DataType::Int32, true)]);
let values: Vec<Option<i32>> = vec![];
let array = Int32Array::from(values);
let record_batch =
RecordBatch::try_new(Arc::new(schema.clone()), vec![Arc::new(array)])
.unwrap();
+
+ let mut file = tempfile::tempfile().unwrap();
+
{
- let file =
Review Comment:
This is a drive-by cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org