You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2019/12/05 01:39:18 UTC
[GitHub] [incubator-doris] yangzhg commented on a change in pull request
#2362: [FIX] fix arithmetic operation between numeric and non-numeric
yangzhg commented on a change in pull request #2362: [FIX] fix arithmetic operation between numeric and non-numeric
URL: https://github.com/apache/incubator-doris/pull/2362#discussion_r354073386
##########
File path: fe/src/main/java/org/apache/doris/analysis/ArithmeticExpr.java
##########
@@ -133,6 +135,11 @@ public ArithmeticExpr(Operator op, Expr e1, Expr e2) {
if (e2 != null) {
children.add(e2);
}
+ if (children.size() == 1) {
Review comment:
the expr after analyze will be changed, this will cause output table header and user input sql are different e.g.
generating sqlStr at constructor will keep the origin sql
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org