You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vaibhav Gumashta <vg...@hortonworks.com> on 2014/11/16 22:10:44 UTC
Review Request 28109: HiveServer2 dynamic service discovery: use
persistent ephemeral nodes curator recipe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28109/
-----------------------------------------------------------
Review request for hive and Thejas Nair.
Bugs: HIVE-8890
https://issues.apache.org/jira/browse/HIVE-8890
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-8890
Diffs
-----
pom.xml 2156fec
service/pom.xml b9d3a40
service/src/java/org/apache/hive/service/server/HiveServer2.java 17e1d85
Diff: https://reviews.apache.org/r/28109/diff/
Testing
-------
Thanks,
Vaibhav Gumashta
Re: Review Request 28109: HiveServer2 dynamic service discovery: use
persistent ephemeral nodes curator recipe
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28109/#review82516
-----------------------------------------------------------
Ship it!
Ship It!
- Thejas Nair
On April 28, 2015, 6:40 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28109/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 6:40 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-8890
> https://issues.apache.org/jira/browse/HIVE-8890
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-8890
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java c9ee423
> pom.xml 9a1dae9
> service/pom.xml 421bb9b
> service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java ca1eae6
> service/src/java/org/apache/hive/service/server/HiveServer2.java 222cb45
>
> Diff: https://reviews.apache.org/r/28109/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 28109: HiveServer2 dynamic service discovery: use
persistent ephemeral nodes curator recipe
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28109/
-----------------------------------------------------------
(Updated April 28, 2015, 6:40 p.m.)
Review request for hive and Thejas Nair.
Bugs: HIVE-8890
https://issues.apache.org/jira/browse/HIVE-8890
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-8890
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java c9ee423
pom.xml 9a1dae9
service/pom.xml 421bb9b
service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java ca1eae6
service/src/java/org/apache/hive/service/server/HiveServer2.java 222cb45
Diff: https://reviews.apache.org/r/28109/diff/
Testing
-------
Thanks,
Vaibhav Gumashta
Re: Review Request 28109: HiveServer2 dynamic service discovery: use
persistent ephemeral nodes curator recipe
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
> On Jan. 30, 2015, 8:26 p.m., Thejas Nair wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1337
> > <https://reviews.apache.org/r/28109/diff/3/?file=836237#file836237line1337>
> >
> > how about using seconds instead of milliseconds, most people would not care about the millisecond part.
HIVE_ZOOKEEPER_CONNECTION_BASESLEEPTIME uses ms and it is reasonable to expect it to be configured < 1s. I'm thinking it's better to keep consistent units. What do you think?
- Vaibhav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28109/#review70303
-----------------------------------------------------------
On April 28, 2015, 6:40 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28109/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 6:40 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-8890
> https://issues.apache.org/jira/browse/HIVE-8890
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-8890
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java c9ee423
> pom.xml 9a1dae9
> service/pom.xml 421bb9b
> service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java ca1eae6
> service/src/java/org/apache/hive/service/server/HiveServer2.java 222cb45
>
> Diff: https://reviews.apache.org/r/28109/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 28109: HiveServer2 dynamic service discovery: use
persistent ephemeral nodes curator recipe
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28109/#review70303
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/28109/#comment115395>
how about using seconds instead of milliseconds, most people would not care about the millisecond part.
service/src/java/org/apache/hive/service/server/HiveServer2.java
<https://reviews.apache.org/r/28109/#comment115397>
is there a difference between having znodeCreationTimeout=6*20=120 sec and this ?
service/src/java/org/apache/hive/service/server/HiveServer2.java
<https://reviews.apache.org/r/28109/#comment115592>
Instead of waiting for 15 seconds, lets use wait+notify or CountDownLatch .
CountDownLatch is fewer lines of code, and we would not need a separate boolean. Example -
http://stackoverflow.com/questions/14929322/need-to-wait-for-asynchronous-api-callback-before-i-return-from-method-in-java
"A CountDownLatch initialized with a count of one serves as a simple on/off latch" - http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/CountDownLatch.html
- Thejas Nair
On Jan. 27, 2015, 12:27 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28109/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2015, 12:27 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-8890
> https://issues.apache.org/jira/browse/HIVE-8890
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-8890
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 66f436b
> pom.xml c147d45
> service/pom.xml b9d3a40
> service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java b6e851a
> service/src/java/org/apache/hive/service/server/HiveServer2.java 21025a2
>
> Diff: https://reviews.apache.org/r/28109/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 28109: HiveServer2 dynamic service discovery: use
persistent ephemeral nodes curator recipe
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28109/
-----------------------------------------------------------
(Updated Jan. 27, 2015, 12:27 p.m.)
Review request for hive and Thejas Nair.
Bugs: HIVE-8890
https://issues.apache.org/jira/browse/HIVE-8890
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-8890
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 66f436b
pom.xml c147d45
service/pom.xml b9d3a40
service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java b6e851a
service/src/java/org/apache/hive/service/server/HiveServer2.java 21025a2
Diff: https://reviews.apache.org/r/28109/diff/
Testing
-------
Thanks,
Vaibhav Gumashta
Re: Review Request 28109: HiveServer2 dynamic service discovery: use
persistent ephemeral nodes curator recipe
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28109/
-----------------------------------------------------------
(Updated Nov. 17, 2014, 12:11 a.m.)
Review request for hive and Thejas Nair.
Bugs: HIVE-8890
https://issues.apache.org/jira/browse/HIVE-8890
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-8890
Diffs (updated)
-----
pom.xml 2156fec
service/pom.xml b9d3a40
service/src/java/org/apache/hive/service/server/HiveServer2.java 17e1d85
Diff: https://reviews.apache.org/r/28109/diff/
Testing
-------
Thanks,
Vaibhav Gumashta
Re: Review Request 28109: HiveServer2 dynamic service discovery: use
persistent ephemeral nodes curator recipe
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28109/#review61691
-----------------------------------------------------------
service/src/java/org/apache/hive/service/server/HiveServer2.java
<https://reviews.apache.org/r/28109/#comment103469>
I think it would be safer to close the PersistentEphemeralNode on any Exception.
service/src/java/org/apache/hive/service/server/HiveServer2.java
<https://reviews.apache.org/r/28109/#comment103470>
should we deregister if this been deleted, irrespective of znode close failure ?
service/src/java/org/apache/hive/service/server/HiveServer2.java
<https://reviews.apache.org/r/28109/#comment103471>
use logger here ?
service/src/java/org/apache/hive/service/server/HiveServer2.java
<https://reviews.apache.org/r/28109/#comment103472>
instead of retrying for ever, lets quit after some reasonable number of attempts.
maybe upto 5 minutes, checking every few seconds (2 sec ?)
If it fails to delete even after long time (say 5 min), log an error and continue with rest.
- Thejas Nair
On Nov. 16, 2014, 9:10 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28109/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2014, 9:10 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-8890
> https://issues.apache.org/jira/browse/HIVE-8890
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-8890
>
>
> Diffs
> -----
>
> pom.xml 2156fec
> service/pom.xml b9d3a40
> service/src/java/org/apache/hive/service/server/HiveServer2.java 17e1d85
>
> Diff: https://reviews.apache.org/r/28109/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>