[GitHub] [incubator-tvm] areusch commented on a change in pull request #5960: [Target] Migrate data structure of TargetNode

[GitBox <gi...@apache.org>]

areusch commented on a change in pull request #5960:
URL: https://github.com/apache/incubator-tvm/pull/5960#discussion_r449140041



##########
File path: src/target/codegen.cc
##########
@@ -47,7 +47,12 @@ runtime::Module Build(IRModule mod, const Target& target) {
           .value()) {
     mod = tir::transform::SkipAssert()(mod);
   }
-  std::string build_f_name = "target.build." + target->target_name;
+  std::string build_f_name;
+  if (target->id->name == "micro_dev") {

Review comment:
       in the future i'd like to remove `micro_dev` as a special target name, but we haven't come to consensus on that, so it's fine for now. 

##########
File path: tests/micro/test_runtime_micro_on_arm.py
##########
@@ -33,7 +33,7 @@
 # Ex : export CMSIS_ST_PATH="/home/yourid/st/STM32Cube_FW_F7_V1.16.0/Drivers/CMSIS"
 DEV_CONFIG_A = micro.device.arm.stm32f746xx.generate_config("127.0.0.1", 6666)
 DEV_CONFIG_B = micro.device.arm.stm32f746xx.generate_config("127.0.0.1", 6666)
-TARGET = 'c -device=micro_dev'
+TARGET = 'micro_dev'

Review comment:
       I guess the other option would be to add a --runtime attr to c codegen, but I can also do that in a follow-up




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org