You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/07 19:49:56 UTC

[GitHub] [tvm] vinx13 commented on a diff in pull request #11601: [relay] Fix missing virtual destructor

vinx13 commented on code in PR #11601:
URL: https://github.com/apache/tvm/pull/11601#discussion_r891649997


##########
src/relay/transforms/compiler_function_utils.h:
##########
@@ -71,6 +71,7 @@ namespace transforms {
  */
 class GlobalSymbolCache {
  public:
+  virtual ~GlobalSymbolCache();

Review Comment:
   nit: for simplicity, we have the implmentation inlined here
   ```suggestion
     virtual ~GlobalSymbolCache() = default;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org