You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/14 08:39:29 UTC
[GitHub] [flink] zhuxiaoshang opened a new pull request #14640: [FLINK-20937][Table API/SQL]Drop table can fails, when i create a tab…
zhuxiaoshang opened a new pull request #14640:
URL: https://github.com/apache/flink/pull/14640
…le with "watermark for proctime()" syntax
## What is the purpose of the change
*don't need to resolve schema when drop table *
## Brief change log
*(for example:)*
- *don't need to resolve schema when drop table*
## Verifying this change
This change added tests and can be verified as follows:
*(example:)*
- testDropTableWithWatermakForProcTime
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)no
- The serializers: (yes / no / don't know)no
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)no
- The S3 file system connector: (yes / no / don't know)no
## Documentation
- Does this pull request introduce a new feature? (yes / no)no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14640: [FLINK-20937][Table API/SQL]Drop table can fails, when i create a tab…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14640:
URL: https://github.com/apache/flink/pull/14640#issuecomment-760055828
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd36249da9dfea6f8a8ce9eccfe89c220535131e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12039",
"triggerID" : "cd36249da9dfea6f8a8ce9eccfe89c220535131e",
"triggerType" : "PUSH"
}, {
"hash" : "17ac8f48c293e42e7c5e63c1724112048fc57827",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12087",
"triggerID" : "17ac8f48c293e42e7c5e63c1724112048fc57827",
"triggerType" : "PUSH"
}, {
"hash" : "f913de48135dfcd55733736432a234707959975a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12102",
"triggerID" : "f913de48135dfcd55733736432a234707959975a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17ac8f48c293e42e7c5e63c1724112048fc57827 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12087)
* f913de48135dfcd55733736432a234707959975a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12102)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14640: [FLINK-20937][Table API/SQL]Drop table can fails, when i create a tab…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14640:
URL: https://github.com/apache/flink/pull/14640#issuecomment-760055828
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd36249da9dfea6f8a8ce9eccfe89c220535131e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12039",
"triggerID" : "cd36249da9dfea6f8a8ce9eccfe89c220535131e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd36249da9dfea6f8a8ce9eccfe89c220535131e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12039)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14640: [FLINK-20937][Table API/SQL]Drop table can fails, when i create a tab…
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14640:
URL: https://github.com/apache/flink/pull/14640#discussion_r557362687
##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/catalog/CatalogManagerTest.java
##########
@@ -160,6 +167,43 @@ public void testDropTemporaryTable() throws Exception {
manager.qualifyIdentifier(UnresolvedIdentifier.of("test")), false);
}
+ @Test
+ public void testDropTableWithWatermakForProcTime() throws Exception {
Review comment:
A simpliest way is adding a test in `org.apache.flink.table.planner.catalog.CatalogTableITCase` where you can use SQL DDL to register tables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14640: [FLINK-20937][Table API/SQL]Drop table can fails, when i create a tab…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14640:
URL: https://github.com/apache/flink/pull/14640#issuecomment-760055828
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd36249da9dfea6f8a8ce9eccfe89c220535131e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12039",
"triggerID" : "cd36249da9dfea6f8a8ce9eccfe89c220535131e",
"triggerType" : "PUSH"
}, {
"hash" : "17ac8f48c293e42e7c5e63c1724112048fc57827",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12087",
"triggerID" : "17ac8f48c293e42e7c5e63c1724112048fc57827",
"triggerType" : "PUSH"
}, {
"hash" : "f913de48135dfcd55733736432a234707959975a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12102",
"triggerID" : "f913de48135dfcd55733736432a234707959975a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f913de48135dfcd55733736432a234707959975a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12102)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14640: [FLINK-20937][Table API/SQL]Drop table can fails, when i create a tab…
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14640:
URL: https://github.com/apache/flink/pull/14640
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14640: [FLINK-20937][Table API/SQL]Drop table can fails, when i create a tab…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14640:
URL: https://github.com/apache/flink/pull/14640#issuecomment-760055828
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd36249da9dfea6f8a8ce9eccfe89c220535131e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12039",
"triggerID" : "cd36249da9dfea6f8a8ce9eccfe89c220535131e",
"triggerType" : "PUSH"
}, {
"hash" : "17ac8f48c293e42e7c5e63c1724112048fc57827",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12087",
"triggerID" : "17ac8f48c293e42e7c5e63c1724112048fc57827",
"triggerType" : "PUSH"
}, {
"hash" : "f913de48135dfcd55733736432a234707959975a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f913de48135dfcd55733736432a234707959975a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17ac8f48c293e42e7c5e63c1724112048fc57827 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12087)
* f913de48135dfcd55733736432a234707959975a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14640: [FLINK-20937][Table API/SQL]Drop table can fails, when i create a tab…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14640:
URL: https://github.com/apache/flink/pull/14640#issuecomment-760055828
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd36249da9dfea6f8a8ce9eccfe89c220535131e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cd36249da9dfea6f8a8ce9eccfe89c220535131e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd36249da9dfea6f8a8ce9eccfe89c220535131e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14640: [FLINK-20937][Table API/SQL]Drop table can fails, when i create a tab…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14640:
URL: https://github.com/apache/flink/pull/14640#issuecomment-760025295
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit cd36249da9dfea6f8a8ce9eccfe89c220535131e (Thu Jan 14 08:43:56 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14640: [FLINK-20937][Table API/SQL]Drop table can fails, when i create a tab…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14640:
URL: https://github.com/apache/flink/pull/14640#issuecomment-760055828
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd36249da9dfea6f8a8ce9eccfe89c220535131e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12039",
"triggerID" : "cd36249da9dfea6f8a8ce9eccfe89c220535131e",
"triggerType" : "PUSH"
}, {
"hash" : "17ac8f48c293e42e7c5e63c1724112048fc57827",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "17ac8f48c293e42e7c5e63c1724112048fc57827",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd36249da9dfea6f8a8ce9eccfe89c220535131e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12039)
* 17ac8f48c293e42e7c5e63c1724112048fc57827 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14640: [FLINK-20937][Table API/SQL]Drop table can fails, when i create a tab…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14640:
URL: https://github.com/apache/flink/pull/14640#issuecomment-760055828
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd36249da9dfea6f8a8ce9eccfe89c220535131e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12039",
"triggerID" : "cd36249da9dfea6f8a8ce9eccfe89c220535131e",
"triggerType" : "PUSH"
}, {
"hash" : "17ac8f48c293e42e7c5e63c1724112048fc57827",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12087",
"triggerID" : "17ac8f48c293e42e7c5e63c1724112048fc57827",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd36249da9dfea6f8a8ce9eccfe89c220535131e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12039)
* 17ac8f48c293e42e7c5e63c1724112048fc57827 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12087)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14640: [FLINK-20937][Table API/SQL]Drop table can fails, when i create a tab…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14640:
URL: https://github.com/apache/flink/pull/14640#issuecomment-760055828
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd36249da9dfea6f8a8ce9eccfe89c220535131e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12039",
"triggerID" : "cd36249da9dfea6f8a8ce9eccfe89c220535131e",
"triggerType" : "PUSH"
}, {
"hash" : "17ac8f48c293e42e7c5e63c1724112048fc57827",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12087",
"triggerID" : "17ac8f48c293e42e7c5e63c1724112048fc57827",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17ac8f48c293e42e7c5e63c1724112048fc57827 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12087)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14640: [FLINK-20937][Table API/SQL]Drop table can fails, when i create a tab…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14640:
URL: https://github.com/apache/flink/pull/14640#issuecomment-760025295
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f913de48135dfcd55733736432a234707959975a (Fri May 28 07:09:04 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org