You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/21 14:22:00 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3126: Don't Skip Serializing Empty Metadata (#3082)

tustvold commented on code in PR #3126:
URL: https://github.com/apache/arrow-rs/pull/3126#discussion_r1028101695


##########
arrow-schema/Cargo.toml:
##########
@@ -45,3 +45,4 @@ default = []
 
 [dev-dependencies]
 serde_json = "1.0"
+postcard = { version = "1.0.2", default-features = false, features = ["alloc"] }

Review Comment:
   I personally would prefer we test using bincode as opposed to postcard, just because the former appears to be more widely adopted. It is a dev dependency so not massively concerned either way, just trying to keep the footprint limited to more mature libraries



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org