You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/28 16:58:09 UTC

[GitHub] [arrow] andygrove commented on pull request #8527: ARROW-10389: [Rust] [DataFusion] Make the custom source implementation API more explicit

andygrove commented on pull request #8527:
URL: https://github.com/apache/arrow/pull/8527#issuecomment-718072011


   Thanks @rdettai I have started reviewing this now. TableProvider existed before we had the physical plan and at physical planning time gets translated into ParquetExec, CsvExec, or MemoryExec.
   
   The ExecutionContext has a register_table method that allows custom table providers to be registered and then referenced by name in the logical plan using the TableScan variant.
   
   It looks like this PR adds an alternate mechanism for acheiving the same goal? I'm not clear on the benefits of this approach over the existing approach but I haven't spent much time looking at this yet.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org