You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/24 15:12:54 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new issue, #662: Consider only output to LOG instead of hardcoded stdout/stderr
PragmaTwice opened a new issue, #662:
URL: https://github.com/apache/incubator-kvrocks/issues/662
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
### Motivation
Refer to https://github.com/apache/incubator-kvrocks/pull/660#issuecomment-1165637383.
It is good to keep kvrocks with only one output location.
But currently, kvrocks also outputs some information to stdout when logdir is set to a regular file, which can be confusing for users.
### Solution
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on issue #662: Consider only output to LOG instead of hardcoded stdout/stderr
Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #662:
URL: https://github.com/apache/incubator-kvrocks/issues/662#issuecomment-1288087609
> cc @git-hulk
>
> <img alt="image" width="1728" src="https://user-images.githubusercontent.com/18818196/197383662-02ed392d-69be-447a-82e6-f2b0c0cd6870.png">
>
> Currently, I found only these three lines in the source code that we print to the stdout in starting up logic. I don't know whether we should have a rule that only output to LOG everywhere and the current status looks good to me.
To be honest, we don't have an explicit rule on when should send logs to the stdout instead of LOG file, but I think all logs should go into LOG except:
- command outputs like `./kvrock --help`
- logs before the logging instance was setup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on issue #662: Consider only output to LOG instead of hardcoded stdout/stderr
Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #662:
URL: https://github.com/apache/incubator-kvrocks/issues/662#issuecomment-1288087737
> Actually something is unexpectedly written to stderr:
>
> 
>
> So it need some investigation.
Yes, I searched the keyword `cout` and found some places are still using `std::cout`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #662: Consider only output to LOG instead of hardcoded stdout/stderr
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on issue #662:
URL: https://github.com/apache/incubator-kvrocks/issues/662#issuecomment-1288070666
Actually something is unexpectedly written to stderr:
So it need some investigation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on issue #662: Consider only output to LOG instead of hardcoded stdout/stderr
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #662:
URL: https://github.com/apache/incubator-kvrocks/issues/662#issuecomment-1288057449
cc @git-hulk
<img width="1728" alt="image" src="https://user-images.githubusercontent.com/18818196/197383662-02ed392d-69be-447a-82e6-f2b0c0cd6870.png">
Currently, I found only these three lines in the source code that we print to the stdout in starting up logic. I don't know whether we should have a rule that only output to LOG everywhere and the current status looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org