[jira] [Commented] (OOZIE-2190) Fix conflicts between generated filenames and user filenames in actions

["Rohini Palaniswamy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389282#comment-14389282 ] 

Rohini Palaniswamy commented on OOZIE-2190:
-------------------------------------------

This is good instead of having to painfully add them to job xml. We added getShareLibFilesForActionConf to methods to get files that will have conflict (currently only hive-site.xml) and add them directly to action xml if they were part of sharelib (Previously hive-site.xml in sharelib was not possible). But it does not address cases where user has specified <file>hive-site.xml</file>. Please rename that method to give a more common name and reuse it for this jira for hive and sqoop.

> Fix conflicts between generated filenames and user filenames in actions
> -----------------------------------------------------------------------
>
>                 Key: OOZIE-2190
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2190
>             Project: Oozie
>          Issue Type: Bug
>          Components: action
>            Reporter: Robert Kanter
>
> We've seen issues where if you have a hive-site.xml with the Hive action or a sqoop-site.xml with the Sqoop action, it fails because of a name conflict (the action wants to write a file with the same name).  We should go through all of the actions and look for any filenames that go into the working directory and try to fix these name conflicts.  Here are some ideas on how to fix this:
> # Generate a subdir in the working directory named "oozie-<timestamp>" and put all files generated by the action in there; it would be extremely unlikely for the user to have a directory named that.
> # Before creating any files in the action, we check if that file already exists and if so, rename it
> # Add "-<timestamp>" to the filenames generated by actions
> I think option 1 is the easiest and best for maintainability.  We can make some helper method that all of the actions can use that returns the directory that's created and just make sure to put any created files in there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)