You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/21 19:13:56 UTC

[GitHub] [spark] ueshin commented on a change in pull request #32177: [SPARK-34999][PYTHON] Consolidate PySpark testing utils

ueshin commented on a change in pull request #32177:
URL: https://github.com/apache/spark/pull/32177#discussion_r617802092



##########
File path: python/pyspark/pandas/tests/plot/test_frame_plot_matplotlib.py
##########
@@ -25,7 +25,11 @@
 
 from pyspark import pandas as ps
 from pyspark.pandas.config import set_option, reset_option
-from pyspark.pandas.testing.utils import have_matplotlib, ReusedSQLTestCase, TestUtils
+from pyspark.testing.pandasutils import (
+    have_matplotlib,
+    matplotlib_requirement_message,
+    ReusedSQLTestCase, TestUtils

Review comment:
       nit: style. Shall we break the line between `ReusedSQLTestCase` and `TestUtils`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org