You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@xtable.apache.org by "vinishjail97 (via GitHub)" <gi...@apache.org> on 2024/12/14 02:53:19 UTC

[PR] Normalize basePath in targetTables in ConversionController [incubator-xtable]

vinishjail97 opened a new pull request, #601:
URL: https://github.com/apache/incubator-xtable/pull/601

   ## *Important Read*
   - *Please ensure the GitHub issue is mentioned at the beginning of the PR*
   
   ## What is the purpose of the pull request
   
   When iceberg tables are used as source, they can have different basePath and dataPaths, when synchronizing these tables to hudi and delta, the .hoodie and _delta_log directories should be present in `basePath/data/.hoodie`, the current code generates the metadata at `basePath/.hoodie`
   
   
   ## Brief change log
   
   *(for example:)*
   - *Fixes the target base paths when source table format is ICEBERG with different basePath and dataPath*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
   - *xtable-core/src/test/java/org/apache/xtable/ITConversionController.java*
   - * xtable-core/src/test/java/org/apache/xtable/conversion/TestConversionUtils.java*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Normalize basePath in targetTables in ConversionController [incubator-xtable]

Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.

vinishjail97 closed pull request #601: Normalize basePath in targetTables in ConversionController
URL: https://github.com/apache/incubator-xtable/pull/601


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Normalize basePath in targetTables in ConversionController [incubator-xtable]

Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.

vinishjail97 commented on PR #601:
URL: https://github.com/apache/incubator-xtable/pull/601#issuecomment-2542841122

   Closing this one as it's directly pushed to origin. 
   https://github.com/apache/incubator-xtable/pull/602 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org