[GitHub] eolivelli commented on a change in pull request #657: Use hash set with native ints for write set tracking

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #657: Use hash set with native ints for write set tracking
URL: https://github.com/apache/bookkeeper/pull/657#discussion_r146650781
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LocalBookieEnsemblePlacementPolicy.java
 ##########
 @@ -88,14 +89,16 @@ public BookieSocketAddress replaceBookie(int ensembleSize, int writeQuorumSize,
     }
 
     @Override
-    public List<Integer> reorderReadSequence(ArrayList<BookieSocketAddress> ensemble, List<Integer> writeSet,
-                                             Map<BookieSocketAddress, Long> bookieFailureHistory) {
+    public IntArrayList reorderReadSequence(
 
 Review comment:
   We are breaking compatibility. We already did break compatibility for policy in 4.5....
   Anyway if you have I would like to have a BK  class

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services