You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "drpmma (via GitHub)" <gi...@apache.org> on 2023/10/23 11:57:36 UTC
[PR] [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE [rocketmq]
drpmma opened a new pull request, #7494:
URL: https://github.com/apache/rocketmq/pull/7494
* introduce a new event NettyEventType.ACTIVE,
* implement channelActive interface for NettyRemotingClient#NettyConnectManageHandler
* add onChannelActive for ChannelEventListener interface.
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #7493
### Brief Description
Introduce a new event NettyEventType.ACTIVE for ChannelEventListener
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7494:
URL: https://github.com/apache/rocketmq/pull/7494#issuecomment-1775075331
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7494](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d1922de) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/f0f15b5e21acd3caf9141375be5db3ef726a2173?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f0f15b5) will **increase** coverage by `0.05%`.
> Report is 3 commits behind head on develop.
> The diff coverage is `22.22%`.
```diff
@@ Coverage Diff @@
## develop #7494 +/- ##
=============================================
+ Coverage 42.93% 42.99% +0.05%
- Complexity 9660 9676 +16
=============================================
Files 1161 1161
Lines 83930 83950 +20
Branches 10898 10899 +1
=============================================
+ Hits 36038 36094 +56
+ Misses 43410 43385 -25
+ Partials 4482 4471 -11
```
| [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/rocketmq/remoting/netty/NettyEventType.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5RXZlbnRUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...che/rocketmq/acl/plain/PlainPermissionManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUGxhaW5QZXJtaXNzaW9uTWFuYWdlci5qYXZh) | `78.37% <0.00%> (ø)` | |
| [...ketmq/broker/client/ClientHousekeepingService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvY2xpZW50L0NsaWVudEhvdXNla2VlcGluZ1NlcnZpY2UuamF2YQ==) | `30.30% <0.00%> (-0.95%)` | :arrow_down: |
| [...rocketmq/controller/BrokerHousekeepingService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9Ccm9rZXJIb3VzZWtlZXBpbmdTZXJ2aWNlLmphdmE=) | `58.33% <0.00%> (-5.31%)` | :arrow_down: |
| [...q/namesrv/routeinfo/BrokerHousekeepingService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9yb3V0ZWluZm8vQnJva2VySG91c2VrZWVwaW5nU2VydmljZS5qYXZh) | `63.63% <0.00%> (-6.37%)` | :arrow_down: |
| [...etmq/proxy/remoting/ClientHousekeepingService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3JlbW90aW5nL0NsaWVudEhvdXNla2VlcGluZ1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rocketmq/remoting/netty/NettyRemotingAbstract.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdBYnN0cmFjdC5qYXZh) | `56.80% <0.00%> (-0.34%)` | :arrow_down: |
| [...e/rocketmq/remoting/netty/NettyRemotingClient.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `40.55% <66.66%> (+0.25%)` | :arrow_up: |
| [.../container/ContainerClientHouseKeepingService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29udGFpbmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb250YWluZXIvQ29udGFpbmVyQ2xpZW50SG91c2VLZWVwaW5nU2VydmljZS5qYXZh) | `7.14% <0.00%> (-0.55%)` | :arrow_down: |
| [...rocketmq/client/impl/factory/MQClientInstance.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | `43.89% <0.00%> (-0.07%)` | :arrow_down: |
... and [24 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7494/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE [rocketmq]
Posted by "drpmma (via GitHub)" <gi...@apache.org>.
drpmma merged PR #7494:
URL: https://github.com/apache/rocketmq/pull/7494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org